Re: [PATCH 2/4] kvm, vmx: move register clearing out of assembly path

From: "Stecklina, Julian" <jsteckli@amazon.de>
To: "jmattson@google.com" <jmattson@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"js@alien8.de" <js@alien8.de>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/4] kvm, vmx: move register clearing out of assembly path
Date: Fri, 26 Oct 2018 10:31:26 +0000	[thread overview]
Message-ID: <1540549886.30273.54.camel@amazon.de> (raw)
In-Reply-To: <CALMp9eQBhz1fzN4z=oMy5X9OKN3JxNyiD4GBYbH+fhen_aP6Ww@mail.gmail.com>

On Thu, 2018-10-25 at 09:55 -0700, Jim Mattson wrote:
> Looking at the second asm statement and the comment that precedes it,
> my first question would be, "What about the registers not covered
> here?"

Good point. I'll make the comment a bit clearer.

>  I'm also not convinced that the register-clearing asm statement
> is actually "clearer" with some registers cleared as input arguments
> and others cleared explicitly, but otherwise, the change looks fine
> to
> me.

The inline assembly itself may not be clearer, but it has a single
purpose now. You are free to ignore it if you want to change aspects of
the VM entry path. It almost fits on a single screen now. ;)

> 
> Reviewed-by: Jim Mattson <jmattson@google.com>

Thanks!
Julian
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B