From: Mike Galbraith <efault@gmx.de>
To: Roman Gushchin <guro@fb.com>
Cc: Michal Hocko <mhocko@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: memcg oops: memcg_kmem_charge_memcg()->try_charge()->page_counter_try_charge()->BOOM
Date: Mon, 29 Oct 2018 21:46:54 +0100 [thread overview]
Message-ID: <1540846014.4434.10.camel@gmx.de> (raw)
In-Reply-To: <20181029185412.GA15760@tower.DHCP.thefacebook.com>
On Mon, 2018-10-29 at 18:54 +0000, Roman Gushchin wrote:
>
> Hi Mike!
>
> Thank you for the report!
>
> Do you see it reliable every time you boot up the machine?
Yeah.
> How do you run kvm?
My VMs are full SW/data clones of my i7-4790/openSUSE <release> box.
> Is there something special about your cgroup setup?
No, I generally have no use for cgroups.
> I've made several attempts to reproduce the issue, but haven't got anything
> so far. I've used your config, and played with different cgroups setups.
Ah, I have cgroup_disable=memory on the command line, which turns out
to be why your box doesn't explode, while mine does.
> Do you know where in the page_counter_try_charge() it fails?
>
> Also, can you, please, check if the following patch mitigates the problem?
Yeah, that plugs it up.
-Mike
next prev parent reply other threads:[~2018-10-29 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 6:00 memcg oops: memcg_kmem_charge_memcg()->try_charge()->page_counter_try_charge()->BOOM Mike Galbraith
2018-10-29 13:20 ` Michal Hocko
2018-10-29 16:35 ` Mike Galbraith
2018-10-29 18:54 ` Roman Gushchin
2018-10-29 20:26 ` Michal Hocko
2018-10-29 21:47 ` Roman Gushchin
2018-10-29 20:46 ` Mike Galbraith [this message]
2018-10-29 21:49 ` Roman Gushchin
2018-10-30 3:14 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540846014.4434.10.camel@gmx.de \
--to=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).