linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]  kvmclock : convert to SPDX identifiers
@ 2018-10-31 17:33 Peng Hao
  2018-11-01 10:14 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Hao @ 2018-10-31 17:33 UTC (permalink / raw)
  To: rkrcmar, tglx, pbonzini; +Cc: x86, kvm, linux-kernel, Peng Hao


From: Peng Hao <peng.hao2@zte.com.cn>

This patch updates license to use SPDX-License-Identifier
instead of verbose license text

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 arch/x86/kernel/kvmclock.c | 15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)

diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 1e67646..0ebd715 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -1,19 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
 /*  KVM paravirtual clock driver. A clocksource implementation
     Copyright (C) 2008 Glauber de Oliveira Costa, Red Hat Inc.
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */
 
 #include <linux/clocksource.h>
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kvmclock : convert to SPDX identifiers
  2018-10-31 17:33 [PATCH] kvmclock : convert to SPDX identifiers Peng Hao
@ 2018-11-01 10:14 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2018-11-01 10:14 UTC (permalink / raw)
  To: Peng Hao; +Cc: rkrcmar, pbonzini, x86, kvm, linux-kernel, Peng Hao

Peng,

On Wed, 31 Oct 2018, Peng Hao wrote:

a few nitpicks upfront. The proper prefix for this is: x86/kvmclock

Most of the time, you can deduce the prefix from running 'git log
path/to/file'.

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

git grep 'This patch' Documentation/process

> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  arch/x86/kernel/kvmclock.c | 15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 1e67646..0ebd715 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -1,19 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0

But, this is the wrong tag. The verbose text has:

> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.

So what you want here is: GPL-2.0+ or GPL-2.0-or-later

You really need to be very careful when replacing boiler plate text with
SPDX identifiers.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-01 10:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-31 17:33 [PATCH] kvmclock : convert to SPDX identifiers Peng Hao
2018-11-01 10:14 ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).