linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask
@ 2018-11-01 11:51 Rohit kumar
  2018-11-01 12:25 ` Srinivas Kandagatla
  2018-11-05 11:57 ` Applied "ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Rohit kumar @ 2018-11-01 11:51 UTC (permalink / raw)
  To: plai, bgoswami, lgirdwood, broonie, perex, tiwai, alsa-devel,
	linux-kernel, rohkumar, srinivas.kandagatla, rohitkr,
	niklas.cassel

SD line mask for MI2S starts from BIT 0 instead of BIT 1.
Fix all bit mask for MI2S SD lines.

Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
---
 sound/soc/qcom/qdsp6/q6afe.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
index 000775b..829b5e987 100644
--- a/sound/soc/qcom/qdsp6/q6afe.c
+++ b/sound/soc/qcom/qdsp6/q6afe.c
@@ -49,14 +49,14 @@
 #define AFE_PORT_I2S_SD1		0x2
 #define AFE_PORT_I2S_SD2		0x3
 #define AFE_PORT_I2S_SD3		0x4
-#define AFE_PORT_I2S_SD0_MASK		BIT(0x1)
-#define AFE_PORT_I2S_SD1_MASK		BIT(0x2)
-#define AFE_PORT_I2S_SD2_MASK		BIT(0x3)
-#define AFE_PORT_I2S_SD3_MASK		BIT(0x4)
-#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(2, 1)
-#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(4, 3)
-#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(3, 1)
-#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(4, 1)
+#define AFE_PORT_I2S_SD0_MASK		BIT(0x0)
+#define AFE_PORT_I2S_SD1_MASK		BIT(0x1)
+#define AFE_PORT_I2S_SD2_MASK		BIT(0x2)
+#define AFE_PORT_I2S_SD3_MASK		BIT(0x3)
+#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(1, 0)
+#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(3, 2)
+#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(2, 0)
+#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(3, 0)
 #define AFE_PORT_I2S_QUAD01		0x5
 #define AFE_PORT_I2S_QUAD23		0x6
 #define AFE_PORT_I2S_6CHS		0x7
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask
  2018-11-01 11:51 [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask Rohit kumar
@ 2018-11-01 12:25 ` Srinivas Kandagatla
  2018-11-05 11:57 ` Applied "ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2018-11-01 12:25 UTC (permalink / raw)
  To: Rohit kumar, plai, bgoswami, lgirdwood, broonie, perex, tiwai,
	alsa-devel, linux-kernel, rohkumar, niklas.cassel



On 01/11/18 11:51, Rohit kumar wrote:
> SD line mask for MI2S starts from BIT 0 instead of BIT 1.
> Fix all bit mask for MI2S SD lines.
> 
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---
>   sound/soc/qcom/qdsp6/q6afe.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
> index 000775b..829b5e987 100644
> --- a/sound/soc/qcom/qdsp6/q6afe.c
> +++ b/sound/soc/qcom/qdsp6/q6afe.c
> @@ -49,14 +49,14 @@
>   #define AFE_PORT_I2S_SD1		0x2
>   #define AFE_PORT_I2S_SD2		0x3
>   #define AFE_PORT_I2S_SD3		0x4
> -#define AFE_PORT_I2S_SD0_MASK		BIT(0x1)
> -#define AFE_PORT_I2S_SD1_MASK		BIT(0x2)
> -#define AFE_PORT_I2S_SD2_MASK		BIT(0x3)
> -#define AFE_PORT_I2S_SD3_MASK		BIT(0x4)
> -#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(2, 1)
> -#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(4, 3)
> -#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(3, 1)
> -#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(4, 1)
> +#define AFE_PORT_I2S_SD0_MASK		BIT(0x0)
> +#define AFE_PORT_I2S_SD1_MASK		BIT(0x1)
> +#define AFE_PORT_I2S_SD2_MASK		BIT(0x2)
> +#define AFE_PORT_I2S_SD3_MASK		BIT(0x3)
> +#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(1, 0)
> +#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(3, 2)
> +#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(2, 0)
> +#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(3, 0)
>   #define AFE_PORT_I2S_QUAD01		0x5
>   #define AFE_PORT_I2S_QUAD23		0x6
>   #define AFE_PORT_I2S_6CHS		0x7
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask" to the asoc tree
  2018-11-01 11:51 [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask Rohit kumar
  2018-11-01 12:25 ` Srinivas Kandagatla
@ 2018-11-05 11:57 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2018-11-05 11:57 UTC (permalink / raw)
  To: Rohit kumar
  Cc: Mark Brown, plai, bgoswami, lgirdwood, broonie, perex, tiwai,
	alsa-devel, linux-kernel, rohkumar, srinivas.kandagatla, rohitkr,
	niklas.cassel, alsa-devel

The patch

   ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 112b57fa737445b2361be332ce8cc0fd3e2b994e Mon Sep 17 00:00:00 2001
From: Rohit kumar <rohitkr@codeaurora.org>
Date: Thu, 1 Nov 2018 17:21:07 +0530
Subject: [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask

SD line mask for MI2S starts from BIT 0 instead of BIT 1.
Fix all bit mask for MI2S SD lines.

Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/qcom/qdsp6/q6afe.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
index 000775b4bba8..829b5e987b2a 100644
--- a/sound/soc/qcom/qdsp6/q6afe.c
+++ b/sound/soc/qcom/qdsp6/q6afe.c
@@ -49,14 +49,14 @@
 #define AFE_PORT_I2S_SD1		0x2
 #define AFE_PORT_I2S_SD2		0x3
 #define AFE_PORT_I2S_SD3		0x4
-#define AFE_PORT_I2S_SD0_MASK		BIT(0x1)
-#define AFE_PORT_I2S_SD1_MASK		BIT(0x2)
-#define AFE_PORT_I2S_SD2_MASK		BIT(0x3)
-#define AFE_PORT_I2S_SD3_MASK		BIT(0x4)
-#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(2, 1)
-#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(4, 3)
-#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(3, 1)
-#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(4, 1)
+#define AFE_PORT_I2S_SD0_MASK		BIT(0x0)
+#define AFE_PORT_I2S_SD1_MASK		BIT(0x1)
+#define AFE_PORT_I2S_SD2_MASK		BIT(0x2)
+#define AFE_PORT_I2S_SD3_MASK		BIT(0x3)
+#define AFE_PORT_I2S_SD0_1_MASK		GENMASK(1, 0)
+#define AFE_PORT_I2S_SD2_3_MASK		GENMASK(3, 2)
+#define AFE_PORT_I2S_SD0_1_2_MASK	GENMASK(2, 0)
+#define AFE_PORT_I2S_SD0_1_2_3_MASK	GENMASK(3, 0)
 #define AFE_PORT_I2S_QUAD01		0x5
 #define AFE_PORT_I2S_QUAD23		0x6
 #define AFE_PORT_I2S_6CHS		0x7
-- 
2.19.0.rc2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-05 11:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 11:51 [PATCH] ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask Rohit kumar
2018-11-01 12:25 ` Srinivas Kandagatla
2018-11-05 11:57 ` Applied "ASoC: qdsp6: q6afe: Fix wrong MI2S SD line mask" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).