From: Chris Wilson <chris@chris-wilson.co.uk>
To: Robert Foss <robert.foss@collabora.com>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robdclark@gmail.com
Cc: Robert Foss <robert.foss@collabora.com>
Subject: Re: [PATCH v2] drm/msm: Move fence put to where failure occurs
Date: Fri, 02 Nov 2018 12:16:40 +0000 [thread overview]
Message-ID: <154116100076.30246.13155169401499183452@skylake-alporthouse-com> (raw)
In-Reply-To: <20181102121313.23271-1-robert.foss@collabora.com>
Quoting Robert Foss (2018-11-02 12:13:13)
> If dma_fence_wait fails to wait for a supplied in-fence in
> msm_ioctl_gem_submit, make sure we release that in-fence.
>
> Also remove this dma_fence_put() from the 'out' label.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Rob, this probably merits a cc:stable tag -- if the wait was interrupted
by a signal, the fence would be leaked.
-Chris
next prev parent reply other threads:[~2018-11-02 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 12:13 [PATCH v2] drm/msm: Move fence put to where failure occurs Robert Foss
2018-11-02 12:16 ` Chris Wilson [this message]
2018-11-02 12:30 ` Robert Foss
2018-11-02 12:29 ` Robert Foss
2018-11-02 13:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154116100076.30246.13155169401499183452@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).