From: Wei Ni <wni@nvidia.com>
To: <thierry.reding@gmail.com>, <daniel.lezcano@linaro.org>,
<linux-tegra@vger.kernel.org>
Cc: <rui.zhang@intel.com>, <edubezval@gmail.com>,
<linux-kernel@vger.kernel.org>, Wei Ni <wni@nvidia.com>
Subject: [PATCH v1 4/4] thermal: tegra: fix coverity defect
Date: Mon, 5 Nov 2018 17:32:34 +0800 [thread overview]
Message-ID: <1541410354-19090-5-git-send-email-wni@nvidia.com> (raw)
In-Reply-To: <1541410354-19090-1-git-send-email-wni@nvidia.com>
Fix dereference dev before null check.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
drivers/thermal/tegra/soctherm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 3042837364e8..96527df91f2a 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -397,7 +397,7 @@ static int throttrip_program(struct device *dev,
struct soctherm_throt_cfg *stc,
int trip_temp)
{
- struct tegra_soctherm *ts = dev_get_drvdata(dev);
+ struct tegra_soctherm *ts;
int temp, cpu_throt, gpu_throt;
unsigned int throt;
u32 r, reg_off;
@@ -405,6 +405,8 @@ static int throttrip_program(struct device *dev,
if (!sg || !stc || !stc->init)
return -EINVAL;
+ ts = dev_get_drvdata(dev);
+
temp = enforce_temp_range(dev, trip_temp) / ts->soc->thresh_grain;
/* Hardcode LIGHT on LEVEL1 and HEAVY on LEVEL2 */
--
2.7.4
next prev parent reply other threads:[~2018-11-05 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 9:32 [PATCH v1 0/4] Fixes for Tegra soctherm Wei Ni
2018-11-05 9:32 ` [PATCH v1 1/4] thermal: tegra: continue if sensor register fails Wei Ni
2018-11-08 12:48 ` Thierry Reding
2018-11-05 9:32 ` [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-08 12:47 ` Thierry Reding
2018-11-09 7:21 ` Wei Ni
2018-11-05 9:32 ` [PATCH v1 3/4] thermal: tegra: fix memory allocation Wei Ni
2018-11-08 12:37 ` Thierry Reding
2018-11-05 9:32 ` Wei Ni [this message]
2018-11-08 12:37 ` [PATCH v1 4/4] thermal: tegra: fix coverity defect Thierry Reding
2018-11-09 6:44 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541410354-19090-5-git-send-email-wni@nvidia.com \
--to=wni@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).