From: Stephen Boyd <sboyd@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
ryder.lee@mediatek.com, Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 1/4] of/device: Add a way to probe drivers by match data
Date: Fri, 09 Nov 2018 08:59:13 -0800 [thread overview]
Message-ID: <154178275324.88331.16237880990995819011@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAMuHMdUTwUTdbKAWCNxH72-tvJuY-LtRO2Dh8izdEOKrFOSwLQ@mail.gmail.com>
Quoting Geert Uytterhoeven (2018-11-09 01:56:01)
> On Wed, Nov 7, 2018 at 7:37 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > Quoting Rob Herring (2018-11-06 12:44:52)
> > > On Tue, Nov 6, 2018 at 12:36 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > int (*probe)(struct platform_device *pdev);
> > };
> >
> > struct of_platform_driver_probe_func mtk_probes[] = {
> > mtk_probe1,
> > mtk_probe2,
> > mtk_probe3,
> > };
> >
> > struct platform_driver mtk_driver = {
> > .of_probes = &mtk_probes;
> > .driver = {
> > .name = "mtk-foo";
> > .of_match_table = mtk_match_table,
> > },
> > };
>
> This looks worse to me: people tend to be very good at keeping multiple
> arrays in sync :-(
To be _not_ very good? Agreed, and so specifying the probe function as
another member in struct of_device_id seems to be the way to go.
next prev parent reply other threads:[~2018-11-09 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 18:36 [PATCH 0/4] Simplify mediatek clk driver probes Stephen Boyd
2018-11-06 18:36 ` [PATCH 1/4] of/device: Add a way to probe drivers by match data Stephen Boyd
2018-11-06 20:44 ` Rob Herring
2018-11-07 18:37 ` Stephen Boyd
2018-11-09 9:56 ` Geert Uytterhoeven
2018-11-09 16:59 ` Stephen Boyd [this message]
2018-11-09 19:18 ` Geert Uytterhoeven
2018-11-30 0:28 ` Stephen Boyd
2018-11-30 1:01 ` Rob Herring
2018-11-30 7:03 ` Stephen Boyd
2018-11-08 8:29 ` Matthias Brugger
2018-11-08 17:58 ` Stephen Boyd
2018-11-09 10:29 ` Matthias Brugger
2018-11-09 10:36 ` Geert Uytterhoeven
2018-11-09 16:30 ` Rob Herring
2018-11-09 16:56 ` Frank Rowand
2018-11-06 18:36 ` [PATCH 2/4] clk: mediatek: Convert to platform_driver_probe_by_match_data() Stephen Boyd
2018-11-06 18:36 ` [PATCH 3/4] clk: mediatek: Drop THIS_MODULE from platform_driver Stephen Boyd
2018-11-06 18:36 ` [PATCH 4/4] clk: mediatek: Simplify single driver probes Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154178275324.88331.16237880990995819011@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).