LKML Archive on lore.kernel.org
 help / color / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Michael Niewöhner" <linux@mniewoehner.de>,
	peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, jgg@ziepe.ca,
	arnd@arndb.de, linux-integrity@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Nuvoton NCPT650 TPM 2.0 mode not working
Date: Sun, 11 Nov 2018 10:57:33 -0800
Message-ID: <1541962653.3190.7.camel@HansenPartnership.com> (raw)
In-Reply-To: <e8eb56fdab618770917fbe5b174328dc1240f934.camel@mniewoehner.de>

On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote:
[...]
> > However, this makes me wonder about yours:
> > 
> > > [    0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO
> > > TC-
> > > S06   00001300 AMI  00000000)
> > 
> > I thought the Lenovo "upgrade to 2.0" in fact disabled the external
> > TPM in favour of the Intel PTT (software TPM in the management
> > engine).  Since you apparently have the tpm_crb driver that should
> > find the PTT TPM, this might be one of the attachment bugs in the
> > CRB driver ... from your ACPI output it looks to be not specifying
> > the Tpm2Tabl.
> 
> Well, there are at least two implementations I know of:
> For my Lenovo X260 I can choose between Infineon TPM 1.2 or Intel PTT
> TPM 2.0 This here is my ThinkStation P320 which can choose between
> PTT 1.2, PTT 2.0,
> Nuvoton 1.2 and 2.0. When switchting between 1.2 and 2.0 the Nuvoton
> gets
> reflashed with the appropriate firmware.

Well, I still think the ACPI setup is incorrect.  What's in
/sys/class/platform (should be directories of ACPI devices)?  The TPM
is supposed to show up as MSFT0101.  If it doesn't is there any other
device string in there that might be a TPM?

James


  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 17:55 Michael Niewöhner
2018-11-11 18:24 ` James Bottomley
2018-11-11 18:50   ` Michael Niewöhner
2018-11-11 18:57     ` James Bottomley [this message]
2018-11-11 20:09       ` Michael Niewöhner
2018-11-11 20:29         ` James Bottomley
2018-11-11 20:34           ` Michael Niewöhner
2018-11-11 21:11             ` Michael Niewöhner
2018-11-11 21:42               ` Mimi Zohar
2018-11-14 20:46                 ` Michael Niewöhner
2018-11-16 21:06                   ` Michael Niewöhner
2018-11-18  8:18                     ` Jarkko Sakkinen
2018-11-18 14:10                       ` Michael Niewöhner
2018-11-19 13:49                         ` Jarkko Sakkinen
2018-11-25 20:06                           ` Michael Niewöhner
2018-11-26 19:15                             ` Michael Niewöhner
2018-11-26 21:13                               ` Jarkko Sakkinen
2018-11-13 10:50               ` Jarkko Sakkinen
2019-01-11 15:40     ` Mimi Zohar
2019-01-12  9:52       ` Michael Niewöhner
2019-01-12 10:49         ` Michael Niewöhner
2018-11-11 18:33 ` Mimi Zohar
2018-11-11 18:51   ` Michael Niewöhner
2018-11-13 10:28 ` Jarkko Sakkinen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541962653.3190.7.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=arnd@arndb.de \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mniewoehner.de \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox