From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F91C43441 for ; Mon, 12 Nov 2018 05:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 867C5216FD for ; Mon, 12 Nov 2018 05:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="Semk9Wi8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 867C5216FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731433AbeKLPYg (ORCPT ); Mon, 12 Nov 2018 10:24:36 -0500 Received: from mail-sn1nam02on0050.outbound.protection.outlook.com ([104.47.36.50]:2704 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727826AbeKLPYg (ORCPT ); Mon, 12 Nov 2018 10:24:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zr/J4DlQESVu3gvUVbV04lhjVZtlgjS2VLwWFICoKFo=; b=Semk9Wi8axzUVoDIsy5gPIwj4MS8g4xte1XbIhgmXDmg3y3dM+SrIVbwTgEnVsOEF9ZRgnehzkWV9nZXVZM6ZQrLUgBoZDnsc55jR1XMm4a4/ecPCCmvfr5A0mylq5NwbXTwKg9tlOMRzyIHI3/THcts7J5CrEB1xHXJZaGuwCk= Received: from BN6PR12CA0026.namprd12.prod.outlook.com (2603:10b6:405:70::12) by DM3PR12MB0747.namprd12.prod.outlook.com (2a01:111:e400:5984::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Mon, 12 Nov 2018 05:32:56 +0000 Received: from CO1NAM03FT004.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e48::207) by BN6PR12CA0026.outlook.office365.com (2603:10b6:405:70::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1294.26 via Frontend Transport; Mon, 12 Nov 2018 05:32:55 +0000 Authentication-Results: spf=none (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=permerror action=none header.from=amd.com; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from SATLEXCHOV01.amd.com (165.204.84.17) by CO1NAM03FT004.mail.protection.outlook.com (10.152.80.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10 via Frontend Transport; Mon, 12 Nov 2018 05:32:54 +0000 Received: from LinuxHost.amd.com (10.34.1.3) by SATLEXCHOV01.amd.com (10.181.40.71) with Microsoft SMTP Server id 14.3.389.1; Sun, 11 Nov 2018 23:32:52 -0600 From: Vijendar Mukunda CC: , , , Vijendar Mukunda , Maruthi Bayyavarapu , Liam Girdwood , "Mark Brown" , Jaroslav Kysela , Takashi Iwai , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 07/11] ASoC: amd: add acp3x i2s ops Date: Mon, 12 Nov 2018 11:04:58 +0530 Message-ID: <1542000903-19020-8-git-send-email-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1542000903-19020-1-git-send-email-Vijendar.Mukunda@amd.com> References: <1542000903-19020-1-git-send-email-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.17;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(376002)(396003)(136003)(39860400002)(2980300002)(428003)(199004)(189003)(446003)(53416004)(305945005)(109986005)(50466002)(105586002)(106466001)(1671002)(36756003)(48376002)(54906003)(8676002)(14444005)(50226002)(8936002)(81156014)(81166006)(11346002)(16586007)(336012)(26005)(356004)(77096007)(53936002)(316002)(5660300001)(68736007)(4326008)(51416003)(426003)(39060400002)(7696005)(47776003)(104016004)(186003)(76176011)(86362001)(126002)(486006)(2906002)(2616005)(478600001)(476003)(72206003)(97736004)(42413003)(266003)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR12MB0747;H:SATLEXCHOV01.amd.com;FPR:;SPF:None;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM03FT004;1:3h/ULVYuUXzWWkBMfCmHsPnRDMAahabhzTfH99fSWdLr6ql9KWJPFgVBCyTYf1EDaZTrXPmv/4hf0qbuqoP+MzkdOwd16oYrXEs4OMv4s8JaCrVhF5KofWBiLi7xwoZH X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 498ca6b4-a9ad-4e41-f547-08d648604be2 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390040)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060);SRVR:DM3PR12MB0747; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0747;3:1hGJroeFUpunIG+PAkNQuRfm9/xujjmW1Mg8M4DR08kTSyXtJp4yhbbg4a6wDI7q4EXpXL6hf+aqmrDXaIw+Xxpc12vDwggSfF/7cDlOC6BNJkuFTPCgYmUUlcyFwlFqZzKMg2c8Zjfobv2UghAUx/5UuxoYRi/Rp8Fmh7YTmWol8S5pOAtdn3RH0VravH+Eo5oFPsNMUoP2Jhpz4ihoLL1MNHfnUEVwYJqBtru/Z2wsYknvVhXh0mA+L5YXTTh8ybSx3ih6iFKBulzayU3vbTo+bo2plyrwKlpdlHZUTXhmUbnrFhpmKu6B/Fw0W0LIT8kVPMZImvURDll6VnMzvBVFHsjiTSVNS/tYxpw7PQ4=;25:gaqZfhJ7E3psd8pbn7gFd1PnHwYiPSzTMK7EWDiI4xotASwQs2Aq02O4nOW64K0VSATghR4mQGzjW6Egd6tFKMjDnkKEo/rE37Ae9vGXRqQ/M4ik3aeUuO5pZn01OFrofHIeXpApypqQeNMBFjVd1lBcXlFlSk1Cuci7FPvH65kVOLkPBYdqfPe5DxZCOdFCNTgOdOPxtoBtyGNi9hGbe5Jyl70e5TborrXMuyuBal/xm7ukuXHXnxKSM9IrwuqGp2UDMVT/bE3ep9SkpCLg+gTI3Lcx6NoM6Y3L9hVaY59HgkxS0jIPiTUquQvS7eWYW4WqSKBQ4GjffaBiDOMYog59jwqTpZRqMZRmBFwcKsw= X-MS-TrafficTypeDiagnostic: DM3PR12MB0747: X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0747;31:vmYWjpMSLqfUTY3FxEkf2qq7ufvJaC/MjXp9c55t7nvEMvlk0NPMLfxIlb6rGLWtK11ajmJM2aCDuTyCapc3rC8O0kKYU/xOgNKkPVupbZ1SASe4ISNcmN/z2vSxDaq88/7T8uMFPpkOINCtvwiUIXmjWhdtKmC84JED8+RaVcq4k6US7oKnbH+3n7AhRmFifmetfJulDWsuuu3/vUEwYqM+WvOcQ2alOVw67odedCQ=;20:AKgN/WHBVnYsiG/B8XtGpMC13wq840A1uxJ484dQc/jMnXjcPU56yrPjRyjExJuOpt9wbClCvYY169HuDXyvsXcWMyhCW9Tgq4Iul5c4ulZF6w0EKFv+aZMNtG4VgwU/TKQTC7ManWmwF7ldm8NcRhCC2h9Zb4Kdr5387FrKf9mpFBoQeKm/sWMcGwp1I/KexVilHk770qpRMMmedz2xfGYY88yuw923ylyl22XiPW4CiyqQClcZ0PbrTHWYoqJGqXuBHULfgbHdpSVv7/aCA/kPCaSR0DEXvnTYSjd1PegZD5gba6XyOsB2nuNrlVpKgceNe/bXF07SKxSotMdrkvaapveQhr9RkWJ96WR4ePdlMmCBdjZPLvyYJr5ZpIQF51xg6Flgz4sR5nuYrVX8zATCTbhWPQAZMoKIrek4mowzycGFzuVmAHhOCg4LizLnniJVB28WimJH4ZT/ZTKDV1TgwXF4tFr/UGBWfsJjCFkRtx3P8+2L/16FiGDfmGgP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105112)(93006095)(93003095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:DM3PR12MB0747;BCL:0;PCL:0;RULEID:;SRVR:DM3PR12MB0747; X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0747;4:d5WGLjk/kQFVK6YfEsaxIygHIZagBokOZmQ9KKPKAEjOv5J8WBPwPRHW9vXelSAwqKSd1mVqI3OACVitYNWEOlkWyXJxYRn7/iRhuu6yM0VEzWqsjJ3+Jt4o3jSMWUCA90jw2AxVjiHfFgBWjloQrxIzIkzVeWR7xoyhtw9PrRx+V9JLBhh3RXBzn3s/6iTHr9/tEMJwwNqOnRzM8S2YXgfb3nbrnR+uSY8S/uRqQin7oESkXLKk6TBsBG+7g3uxjV5Qo96fpvyYxreYNjdojNlRy5CZAEH5YY4ZhLg+HNXH8KTeE9RImgG+RPH6e7vy X-Forefront-PRVS: 0854128AF0 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR12MB0747;23:Ti9W78MCadekB5Lk9K57MISOlI4I3IG8WosHfI6L7?= =?us-ascii?Q?w0ARLUmMAMaU7mMkZaRw+PUXntGyVpbVZNvnf1QShv+udvJHB/k1BmskrZUA?= =?us-ascii?Q?G2OllzYMxyQBo7gUy2EYwFTvzxQdfstE5PrRKMLuVwHiPq+0Ri8uxAL32CO4?= =?us-ascii?Q?akY25KqYIvWi1PaME7NH9ufs0HmTd/PcSF3a1jD2UyO8EcEdVL+qgUZF6yxd?= =?us-ascii?Q?KAjmneUZN9y/LfQeA+rHFO2MD+cnb1s4ZWnQA8FtTDFCZp+dQkvPk1hm1/bu?= =?us-ascii?Q?1+NTLCxG1tNs/3+GMyXj7jrltFAdMWe8wfNm70dzjTb9aYAZyWF23ZOmAK/E?= =?us-ascii?Q?zd74N+ZpqZxSZaL5tsiJTTfy4hzhwRaX0Clcrz3WNzucUm5DKRUq/lwfaNvD?= =?us-ascii?Q?Y5AdcRMoMuH3JBHekp+WAEPtoo5kFCSjn613fPUf1e2y4YIqdraKgvOGF0k7?= =?us-ascii?Q?f5TN6pJXSy+y9eWIQW5hWI/jkfkhKa0JuJjjAgmIkJXtOX1ptM+CTpDI2Irl?= =?us-ascii?Q?S5a8/+RP9f1KTNEJicmX0yu4wwsyERP5ZRXT12Ep+K+G0GpmUTAHPaz2RMjI?= =?us-ascii?Q?qmexNEinV1H2T/WIAQbiUmXBJQS96EU9jbEKKl50DffOAAW9xw7VbmDeZJhx?= =?us-ascii?Q?/40l7IJVcXpzO+vHH6d0C3K61StAEL0mQbxFy7shsJXLTJlp2fwCzlBXTG0L?= =?us-ascii?Q?Gv0zKI/e/yPzN9ryXuyRizU+AYA7zudf0uKgeE2ZFzWYNQ9BLO/SFU2RJESy?= =?us-ascii?Q?tOH/4K6GH6m/sT3Il+ycib24da+jgOtkFkLRPtvHQpd8ykoFRZYCk3xtBayk?= =?us-ascii?Q?wRi3HYUpNgGDPzjrdZ2RUVkNa72+51CvKOm8LKmZgADx4aZkOTbkq2cUkQB+?= =?us-ascii?Q?NqIjs/uCdHRC2HUKLgbyvAdUxFNaNYHngkmp5xjuyr9xIglNm10giwfEzExM?= =?us-ascii?Q?YxiLfuffXHHrtIHERA21W9LJlnAHHZ8C945us5ONqdWMbo0Y/B7B3WaepPK3?= =?us-ascii?Q?qRn4jCLLKFK/vs9Xkg5/mSD13gRcKAJ73jO+maODlH5zejqmCNyJRuctFof2?= =?us-ascii?Q?iJt3dijHKRTNBFegebDhJfd1UlHRzDMAnAGPNYctFPDEUW6w1WaTvs0cwe6L?= =?us-ascii?Q?sjjHuI1N51Kw243xiZpeUVqK/LkbdAHxLUQcyaj0nh6TZaZIuw/Vx/LygSjM?= =?us-ascii?Q?fTRIb1OV6eYgcSjO4Wl6gG+JaIDnKX7xwzPkKUPIa7W95qQtoJ2CU8GHZx3l?= =?us-ascii?Q?Um/ssNZrpabXv8KdoFXIFqmOy4hPpfRRszSluFl?= X-Microsoft-Antispam-Message-Info: 2kqbeAuHUiT8W3zjR6xNQK+ksV5XGaQzMXdOFyzlwWcPv7b/C7fEuGWb6X5tnwpowOvdGvqiV45XAVDl0Wtaj62hvh613FitkiHxAosIBObmIEmpKMGCuRQjf0dDDbCLqdTF81RgpJVwtUvc/JwTl1BtYwzbQ6VjBlq8Ky10rvPZEoYtujS7iEaX56wFfD6LQfLs77hgtB+Gn+WOM+qB6EqonXKuQtmUBuXaZJu51G1fVOl+ZodUIHoZMYuCuoSdgp8Y/ftN+vgRRrRNktwJ+Yzp7qOKNTFjZM74/j2A/NjPe3aJbqxVGGAgv33ieTn6i74wxjXVUOgmQQ2vubkmlaNGCZxbM3wiPwFfsDfcdCM= X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0747;6:9cFAN8d5TXm7kRZYNSec/Tk8s/WRzAyMyCT2fCw7PBXLpej4IAV0viB+drDE1cueJYk0Op4lT4myAsB6ArPhEUVExJ9UkXb1T58sQxuUxolyIfMCwsvpXc24ROzUKz5FEdRuqrI9+NbyokAw6puHsDvqwqmLHkhy/+lBAnhM/SOeTUrUSiLzfR3sc3f0UOTEmWdWNOXtfukKlJAkPukElUDyAXR5GdX0m7kS8k6dL1U1ag9oVx0WXdO5TjiXk8lO+pXgpw7bTToYdcCj8mFEo/ZUCNeN1KZ9YHW1kKiRg4IxfNazmMXlbfvnulVLeKOu42+qbxNTOgBB7mo5SS+wUmfyiZxmniUthHk2QXEfMOM0e5WeU0jNL+sCoVSPpab1G0tgDyc4+VdaDLKwCUiVLF54zQcDkRuvG+mxFVbuY3XaKjrGq00ZC8p7cyJYrtN3+uZgy0mIeLrxMSv2b663GQ==;5:/rdTqnR6dh0yu1luGpSysKwdwHHIDhbUcHoU7uXDIK5cWp/AyTQY+L2KthL3sWaaR+QktrI2ZO+0LdEnQdsiORJpFeDuiKnBSLMRAEXA+f3r5UU/8AOzJgs2KA8hvT0IYPxpZtV2WMAQ/Cj1bvaJlBvqQ/8Gr3y5HxGdipIaV38=;7:+ZfU7rNzVO1yEn1nv3xQEiN+ZZrDapyaMmrsYTegmPTfL7efq5iJ1ELEEM0JpddxyuzsCA8QSBDrfyzdbotScrT4BHLeofxahBojvfONnJDma4Uum0UY8nop0276dumlqIXWKzenfo7YquGrDPnt/Q== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR12MB0747;20:8PEcQkY3d4FoV5NEUZVyZSUSBsixdEKWwgqUCThl5HkvM514s0ej5U110PtAaz3NNdXN233KJjC3bqyRZGvtZtC1zMw1ZAdmv8MeRhIf5ipfFl1Sbb+06cs40Tm1g9+KDO0CUCYAKvVmBQaN5282OYEP4ue/2yFWwYSB3nW/NUQy9t38iWFmR/UpMuztgtNZS6nAIBpADHxqqjF7MMThjnQrgrze48Bz0Z8ywxNymFj3iXZsUg3TavPUaUEhH+9N X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2018 05:32:54.3447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 498ca6b4-a9ad-4e41-f547-08d648604be2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXCHOV01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB0747 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACP3x has a i2s controller block for playback and capture. This patch adds ACP3x i2s DAI operations. Signed-off-by: Maruthi Bayyavarapu Tested-by: Ravulapati Vishnu vardhan Rao Signed-off-by: Vijendar Mukunda --- sound/soc/amd/raven/acp3x-pcm-dma.c | 89 +++++++++++++++++++++++++++++++++++-- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index 06c1985..ed2c163 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -423,10 +423,93 @@ static struct snd_pcm_ops acp3x_dma_ops = { .mmap = acp3x_dma_mmap, }; +static int acp3x_dai_i2s_hwparams(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *dai) +{ + u32 val = 0; + struct i2s_stream_instance *rtd = substream->runtime->private_data; + + switch (params_format(params)) { + case SNDRV_PCM_FORMAT_U8: + case SNDRV_PCM_FORMAT_S8: + rtd->xfer_resolution = 0x0; + break; + case SNDRV_PCM_FORMAT_S16_LE: + rtd->xfer_resolution = 0x02; + break; + case SNDRV_PCM_FORMAT_S24_LE: + rtd->xfer_resolution = 0x04; + break; + case SNDRV_PCM_FORMAT_S32_LE: + rtd->xfer_resolution = 0x05; + break; + default: + return -EINVAL; + } + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER); + val = val | (rtd->xfer_resolution << 3); + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER); + else + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER); + + return 0; +} + +static int acp3x_dai_i2s_trigger(struct snd_pcm_substream *substream, + int cmd, struct snd_soc_dai *dai) +{ + int ret = 0; + struct i2s_stream_instance *rtd = substream->runtime->private_data; + u32 val, period_bytes; + + period_bytes = frames_to_bytes(substream->runtime, + substream->runtime->period_size); + switch (cmd) { + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + rv_writel(period_bytes, rtd->acp3x_base + + mmACP_BT_TX_INTR_WATERMARK_SIZE); + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER); + val = val | BIT(0); + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER); + } else { + rv_writel(period_bytes, rtd->acp3x_base + + mmACP_BT_RX_INTR_WATERMARK_SIZE); + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_IRER); + val = val | BIT(0); + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER); + } + rv_writel(1, rtd->acp3x_base + mmACP_BTTDM_IER); + break; + case SNDRV_PCM_TRIGGER_STOP: + case SNDRV_PCM_TRIGGER_SUSPEND: + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER); + val = val & ~BIT(0); + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER); + } else { + val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_IRER); + val = val & ~BIT(0); + rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_IRER); + } + rv_writel(0, rtd->acp3x_base + mmACP_BTTDM_IER); + break; + default: + ret = -EINVAL; + break; + } + + return ret; +} + struct snd_soc_dai_ops acp3x_dai_i2s_ops = { - .hw_params = NULL, - .trigger = NULL, - .set_fmt = NULL, + .hw_params = acp3x_dai_i2s_hwparams, + .trigger = acp3x_dai_i2s_trigger, }; static struct snd_soc_dai_driver acp3x_i2s_dai_driver = { -- 2.7.4