From: Firoz Khan <firoz.khan@linaro.org>
To: linux-alpha@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org,
firoz.khan@linaro.org
Subject: [PATCH v3 3/5] alpha: add __NR_syscalls along with NR_SYSCALLS
Date: Tue, 13 Nov 2018 15:01:51 +0530 [thread overview]
Message-ID: <1542101513-22010-4-git-send-email-firoz.khan@linaro.org> (raw)
In-Reply-To: <1542101513-22010-1-git-send-email-firoz.khan@linaro.org>
NR_SYSCALLS macro holds the number of system call exist
in alpha architecture. We have to change the value of NR-
_SYSCALLS, if we add or delete a system call.
One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file.
The syscall.tbl file contains the total number of system
calls information. So we have two option to update NR_SY-
CALLS value.
1. Update NR_SYSCALLS in asm/unistd.h manually by count-
ing the no.of system calls. No need to update NR_SYS-
CALLS until we either add a new system call or delete
existing system call.
2. We can keep this feature it above mentioned script,
that will count the number of syscalls and keep it in
a generated file. In this case we don't need to expli-
citly update NR_SYSCALLS in asm/unistd.h file.
The 2nd option will be the recommended one. For that, I
added the __NR_syscalls macro in uapi/asm/unistd.h along
with NR_SYSCALLS asm/unistd.h. The macro __NR_syscalls
also added for making the name convention same across all
architecture. While __NR_syscalls isn't strictly part of
the uapi, having it as part of the generated header to
simplifies the implementation. We also need to enclose
this macro with #ifdef __KERNEL__ to avoid side effects.
Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
arch/alpha/include/asm/unistd.h | 2 +-
arch/alpha/include/uapi/asm/unistd.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/alpha/include/asm/unistd.h b/arch/alpha/include/asm/unistd.h
index 4f0ceb3..21b706a 100644
--- a/arch/alpha/include/asm/unistd.h
+++ b/arch/alpha/include/asm/unistd.h
@@ -4,7 +4,7 @@
#include <uapi/asm/unistd.h>
-#define NR_SYSCALLS 523
+#define NR_SYSCALLS __NR_syscalls
#define __ARCH_WANT_NEW_STAT
#define __ARCH_WANT_OLD_READDIR
diff --git a/arch/alpha/include/uapi/asm/unistd.h b/arch/alpha/include/uapi/asm/unistd.h
index 47c65f1..ab40aa6 100644
--- a/arch/alpha/include/uapi/asm/unistd.h
+++ b/arch/alpha/include/uapi/asm/unistd.h
@@ -465,4 +465,8 @@
#define __NR_pwritev2 521
#define __NR_statx 522
+#ifdef __KERNEL__
+#define __NR_syscalls 523
+#endif
+
#endif /* _UAPI_ALPHA_UNISTD_H */
--
1.9.1
next prev parent reply other threads:[~2018-11-13 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 9:31 [PATCH v3 0/5] alpha: system call table generation support Firoz Khan
2018-11-13 9:31 ` [PATCH v3 1/5] alpha: move __IGNORE* entries to non uapi header Firoz Khan
2018-11-13 9:31 ` [PATCH v3 2/5] alpha: remove CONFIG_OSF4_COMPAT flag from syscall table Firoz Khan
2018-11-13 9:31 ` Firoz Khan [this message]
2018-11-13 9:31 ` [PATCH v3 4/5] alpha: add system call table generation support Firoz Khan
2018-11-13 9:31 ` [PATCH v3 5/5] alpha: generate uapi header and syscall table header files Firoz Khan
2018-12-14 15:17 ` [PATCH v3 0/5] alpha: system call table generation support Firoz Khan
2018-12-19 15:59 ` Matt Turner
2018-12-19 17:08 ` Arnd Bergmann
2018-12-21 16:46 ` Matt Turner
2018-12-22 10:27 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542101513-22010-4-git-send-email-firoz.khan@linaro.org \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=kstewart@linuxfoundation.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mattst88@gmail.com \
--cc=pombredanne@nexb.com \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
--subject='Re: [PATCH v3 3/5] alpha: add __NR_syscalls along with NR_SYSCALLS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).