From: Firoz Khan <firoz.khan@linaro.org> To: Chris Zankel <chris@zankel.net>, Max Filippov <jcmvbkbc@gmail.com>, linux-xtensa@linux-xtensa.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Philippe Ombredanne <pombredanne@nexb.com>, Thomas Gleixner <tglx@linutronix.de>, Kate Stewart <kstewart@linuxfoundation.org> Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org, firoz.khan@linaro.org Subject: [PATCH v2 1/3] xtensa: add __NR_syscalls along with __NR_syscall_count Date: Tue, 13 Nov 2018 15:49:28 +0530 [thread overview] Message-ID: <1542104370-22831-2-git-send-email-firoz.khan@linaro.org> (raw) In-Reply-To: <1542104370-22831-1-git-send-email-firoz.khan@linaro.org> __NR_syscall_count macro holds the number of system call exist in xtensa architecture. We have to change the value of __NR_syscall_count, if we add or delete a system call. One of the patch in this patch series has a script which will generate a uapi header based on syscall.tbl file. The syscall.tbl file contains the total number of system calls information. So we have two option to update __NR- _syscall_count value. 1. Update __NR_syscall_count in asm/unistd.h manually by counting the no.of system calls. No need to update __NR- _syscall_count until we either add a new system call or delete existing system call. 2. We can keep this feature it above mentioned script, that will count the number of syscalls and keep it in a generated file. In this case we don't need to expli- citly update __NR_syscall_count in asm/unistd.h file. The 2nd option will be the recommended one. For that, I added the __NR_syscalls macro in uapi/asm/unistd.h along with __NR_syscall_count asm/unistd.h. The macro __NR_sys- calls also added for making the name convention same across all architecture. While __NR_syscalls isn't strictly part of the uapi, having it as part of the generated header to simplifies the implementation. We also need to enclose this macro with #ifdef __KERNEL__ to avoid side effects. Signed-off-by: Firoz Khan <firoz.khan@linaro.org> --- arch/xtensa/include/asm/unistd.h | 2 ++ arch/xtensa/include/uapi/asm/unistd.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/xtensa/include/asm/unistd.h b/arch/xtensa/include/asm/unistd.h index 574e552..787987a 100644 --- a/arch/xtensa/include/asm/unistd.h +++ b/arch/xtensa/include/asm/unistd.h @@ -5,6 +5,8 @@ #define __ARCH_WANT_SYS_CLONE #include <uapi/asm/unistd.h> +#define __NR_syscall_count __NR_syscalls + #define __ARCH_WANT_NEW_STAT #define __ARCH_WANT_STAT64 #define __ARCH_WANT_SYS_UTIME diff --git a/arch/xtensa/include/uapi/asm/unistd.h b/arch/xtensa/include/uapi/asm/unistd.h index bc3f62d..332d67a 100644 --- a/arch/xtensa/include/uapi/asm/unistd.h +++ b/arch/xtensa/include/uapi/asm/unistd.h @@ -778,7 +778,9 @@ #define __NR_statx 351 __SYSCALL(351, sys_statx, 5) -#define __NR_syscall_count 352 +#ifdef __KERNEL__ +#define __NR_syscalls 352 +#endif /* * sysxtensa syscall handler -- 1.9.1
next prev parent reply other threads:[~2018-11-13 10:20 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-13 10:19 [PATCH v2 0/3] xtensa: system call table generation support Firoz Khan 2018-11-13 10:19 ` Firoz Khan [this message] 2018-11-13 23:49 ` [PATCH v2 1/3] xtensa: add __NR_syscalls along with __NR_syscall_count Max Filippov 2018-11-15 10:05 ` Firoz Khan 2018-11-15 19:45 ` Max Filippov 2018-11-16 5:48 ` Firoz Khan 2018-11-13 10:19 ` [PATCH v2 2/3] xtensa: add system call table generation support Firoz Khan 2018-11-13 10:19 ` [PATCH v2 3/3] xtensa: generate uapi header and syscall table header files Firoz Khan 2018-11-13 23:53 ` [PATCH v2 0/3] xtensa: system call table generation support Max Filippov 2018-11-15 9:57 ` Firoz Khan 2018-11-15 20:16 ` Max Filippov 2018-11-16 5:47 ` Firoz Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1542104370-22831-2-git-send-email-firoz.khan@linaro.org \ --to=firoz.khan@linaro.org \ --cc=arnd@arndb.de \ --cc=chris@zankel.net \ --cc=deepa.kernel@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jcmvbkbc@gmail.com \ --cc=kstewart@linuxfoundation.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xtensa@linux-xtensa.org \ --cc=marcin.juszkiewicz@linaro.org \ --cc=pombredanne@nexb.com \ --cc=tglx@linutronix.de \ --cc=y2038@lists.linaro.org \ --subject='Re: [PATCH v2 1/3] xtensa: add __NR_syscalls along with __NR_syscall_count' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).