linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH trivial] reset: Improve reset controller kernel docs
@ 2018-10-08 11:15 Geert Uytterhoeven
  2018-10-08 12:55 ` Philipp Zabel
  2018-11-13 14:28 ` Philipp Zabel
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-10-08 11:15 UTC (permalink / raw)
  To: Philipp Zabel, Jiri Kosina; +Cc: linux-kernel, Geert Uytterhoeven

Grammar and indentation fixes.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 include/linux/reset.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
  *
  * Returns a struct reset_control or IS_ERR() condition containing errno.
  * This function is intended for use with reset-controls which are shared
- * between hardware-blocks.
+ * among hardware blocks.
  *
  * When a reset-control is shared, the behavior of reset_control_assert /
  * deassert is changed, the reset-core will keep track of a deassert_count
@@ -187,7 +187,7 @@ static inline struct reset_control *of_reset_control_get_exclusive(
 }
 
 /**
- * of_reset_control_get_shared - Lookup and obtain an shared reference
+ * of_reset_control_get_shared - Lookup and obtain a shared reference
  *                               to a reset controller.
  * @node: device to be reset by the controller
  * @id: reset line name
@@ -229,7 +229,7 @@ static inline struct reset_control *of_reset_control_get_exclusive_by_index(
 }
 
 /**
- * of_reset_control_get_shared_by_index - Lookup and obtain an shared
+ * of_reset_control_get_shared_by_index - Lookup and obtain a shared
  *                                        reference to a reset controller
  *                                        by index.
  * @node: device to be reset by the controller
@@ -322,7 +322,7 @@ devm_reset_control_get_exclusive_by_index(struct device *dev, int index)
 
 /**
  * devm_reset_control_get_shared_by_index - resource managed
- * reset_control_get_shared
+ *                                          reset_control_get_shared
  * @dev: device to be reset by the controller
  * @index: index of the reset controller
  *
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH trivial] reset: Improve reset controller kernel docs
  2018-10-08 11:15 [PATCH trivial] reset: Improve reset controller kernel docs Geert Uytterhoeven
@ 2018-10-08 12:55 ` Philipp Zabel
  2018-11-13 15:12   ` Geert Uytterhoeven
  2018-11-13 14:28 ` Philipp Zabel
  1 sibling, 1 reply; 4+ messages in thread
From: Philipp Zabel @ 2018-10-08 12:55 UTC (permalink / raw)
  To: Geert Uytterhoeven, Jiri Kosina; +Cc: linux-kernel

Hi Geert,

On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote:
> Grammar and indentation fixes.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/reset.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
>   *
>   * Returns a struct reset_control or IS_ERR() condition containing errno.
>   * This function is intended for use with reset-controls which are shared
> - * between hardware-blocks.
> + * among hardware blocks.

To my ears "between" sounds better, because it evokes the idea that each
hardware block individually must take care not to disturb any of the
others (like sharing a bike between a few riders, instead of among
them). Also, in many cases the sharing occurs between just two hardware
blocks, which makes "among" sound weird.
Of course I'm not a native speaker, so maybe I'm completely wrong.

The other fixes I agree with.

regards
Philipp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH trivial] reset: Improve reset controller kernel docs
  2018-10-08 11:15 [PATCH trivial] reset: Improve reset controller kernel docs Geert Uytterhoeven
  2018-10-08 12:55 ` Philipp Zabel
@ 2018-11-13 14:28 ` Philipp Zabel
  1 sibling, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2018-11-13 14:28 UTC (permalink / raw)
  To: Geert Uytterhoeven, Jiri Kosina; +Cc: linux-kernel

Hi Geert,

On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote:
> Grammar and indentation fixes.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/reset.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
>   *
>   * Returns a struct reset_control or IS_ERR() condition containing errno.
>   * This function is intended for use with reset-controls which are shared
> - * between hardware-blocks.
> + * among hardware blocks.

For now I have applied this patch without the s/between/among/, which I
am not sure about.

regards
Philipp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH trivial] reset: Improve reset controller kernel docs
  2018-10-08 12:55 ` Philipp Zabel
@ 2018-11-13 15:12   ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-11-13 15:12 UTC (permalink / raw)
  To: Philipp Zabel; +Cc: Geert Uytterhoeven, Jiri Kosina, Linux Kernel Mailing List

Hi Philipp,

On Mon, Oct 8, 2018 at 2:55 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote:
> > Grammar and indentation fixes.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  include/linux/reset.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
> > --- a/include/linux/reset.h
> > +++ b/include/linux/reset.h
> > @@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
> >   *
> >   * Returns a struct reset_control or IS_ERR() condition containing errno.
> >   * This function is intended for use with reset-controls which are shared
> > - * between hardware-blocks.
> > + * among hardware blocks.
>
> To my ears "between" sounds better, because it evokes the idea that each
> hardware block individually must take care not to disturb any of the
> others (like sharing a bike between a few riders, instead of among
> them). Also, in many cases the sharing occurs between just two hardware
> blocks, which makes "among" sound weird.
> Of course I'm not a native speaker, so maybe I'm completely wrong.

I'm not a native speaker.
But I was taught "between" is used for exactly 2 items, and "among" for more
than 2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-13 15:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 11:15 [PATCH trivial] reset: Improve reset controller kernel docs Geert Uytterhoeven
2018-10-08 12:55 ` Philipp Zabel
2018-11-13 15:12   ` Geert Uytterhoeven
2018-11-13 14:28 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).