archive mirror
 help / color / mirror / Atom feed
From: Firoz Khan <>
To: Benjamin Herrenschmidt <>,
	Paul Mackerras <>,
	Michael Ellerman <>,
	Arnd Bergmann <>, Ram Pai <>,
	Geert Uytterhoeven <>,
	Breno Leitao <>,
	Boqun Feng <>,,
	Thomas Gleixner <>,
	Greg Kroah-Hartman <>,
	Philippe Ombredanne <>,
	Kate Stewart <>
Subject: [PATCH v2 1/4] powerpc: add __NR_syscalls along with NR_syscalls
Date: Wed, 14 Nov 2018 15:33:15 +0530	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

NR_syscalls macro holds the number of system call exist
in powerpc architecture. We have to change the value of
NR_syscalls, if we add or delete a system call.

One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file.
The syscall.tbl file contains the number of system call
information. So we have two option to update NR_syscalls

1. Update NR_syscalls in asm/unistd.h manually by count-
   ing the no.of system calls. No need to update NR_sys-
   calls until we either add a new system call or delete
   existing system call.

2. We can keep this feature in above mentioned script,
   that will count the number of syscalls and keep it in
   a generated file. In this case we don't need to expli-
   citly update NR_syscalls in asm/unistd.h file.

The 2nd option will be the recommended one. For that, I
added the __NR_syscalls macro in uapi/asm/unistd.h along
with NR_syscalls asm/unistd.h. The macro __NR_syscalls
also added for making the name convention same across all
architecture. While __NR_syscalls isn't strictly part of
the uapi, having it as part of the generated header to
simplifies the implementation. We also need to enclose
this macro with #ifdef __KERNEL__ to avoid side effects.

Signed-off-by: Firoz Khan <>
 arch/powerpc/include/asm/unistd.h      | 3 +--
 arch/powerpc/include/uapi/asm/unistd.h | 5 ++++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/include/asm/unistd.h b/arch/powerpc/include/asm/unistd.h
index b0de85b..a3c35e6 100644
--- a/arch/powerpc/include/asm/unistd.h
+++ b/arch/powerpc/include/asm/unistd.h
@@ -11,8 +11,7 @@
 #include <uapi/asm/unistd.h>
-#define NR_syscalls		389
+#define NR_syscalls	__NR_syscalls
 #define __NR__exit __NR_exit
diff --git a/arch/powerpc/include/uapi/asm/unistd.h b/arch/powerpc/include/uapi/asm/unistd.h
index 985534d..7195868 100644
--- a/arch/powerpc/include/uapi/asm/unistd.h
+++ b/arch/powerpc/include/uapi/asm/unistd.h
@@ -10,7 +10,6 @@
 #define __NR_restart_syscall	  0
 #define __NR_exit		  1
 #define __NR_fork		  2
@@ -401,4 +400,8 @@
 #define __NR_rseq		387
 #define __NR_io_pgetevents	388
+#ifdef __KERNEL__
+#define __NR_syscalls		389

  reply	other threads:[~2018-11-14 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 10:03 [PATCH v2 0/4] powerpc: system call table generation support Firoz Khan
2018-11-14 10:03 ` Firoz Khan [this message]
2018-11-14 10:03 ` [PATCH v2 2/4] powerpc: move macro definition from asm/systbl.h Firoz Khan
2018-11-19 16:11   ` Arnd Bergmann
2018-11-14 10:03 ` [PATCH v2 3/4] powerpc: add system call table generation support Firoz Khan
2018-11-19 16:48   ` Arnd Bergmann
2018-11-14 10:03 ` [PATCH v2 4/4] powerpc: generate uapi header and system call table files Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 1/4] powerpc: add __NR_syscalls along with NR_syscalls' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).