From: Stephen Boyd <sboyd@kernel.org>
To: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Janek Kotas <jank@cadence.com>
Cc: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: clk: Add bindings for Fixed MMIO clock
Date: Wed, 14 Nov 2018 14:36:27 -0800 [thread overview]
Message-ID: <154223498711.88331.11553475442681784637@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1B94C733-F941-4403-9498-4BBB35B25345@global.cadence.com>
Quoting Janek Kotas (2018-11-14 07:24:21)
> +
> +Required properties:
> +- compatible : shall be "fixed-mmio-clock".
> +- #clock-cells : from common clock binding; shall be set to 0.
> +- reg : Address and length of the clock value register set.
> +
> +Optional properties:
> +- clock-output-names : From common clock binding.
> +
> +Example:
> +sysclock: sysclock@fd020004 {
> + #clock-cells = <0>;
> + compatible = "fixed-mmio-clock";
> + reg = <0xfd020004 0x4>;
Unfortunately this looks wrong and seems to be a way to split up a
hardware IP block into many little DT nodes to describe clks inside of a
clock controller. We don't do that style of clk drivers anymore.
prev parent reply other threads:[~2018-11-14 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 15:24 [PATCH 1/2] dt-bindings: clk: Add bindings for Fixed MMIO clock Janek Kotas
2018-11-14 22:36 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154223498711.88331.11553475442681784637@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).