From: Firoz Khan <firoz.khan@linaro.org>
To: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
linux-mips@linux-mips.org, Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, deepa.kernel@gmail.com,
marcin.juszkiewicz@linaro.org, firoz.khan@linaro.org
Subject: [PATCH v2 1/5] mips: add __NR_syscalls along with __NR_Linux_syscalls
Date: Thu, 15 Nov 2018 11:44:17 +0530 [thread overview]
Message-ID: <1542262461-29024-2-git-send-email-firoz.khan@linaro.org> (raw)
In-Reply-To: <1542262461-29024-1-git-send-email-firoz.khan@linaro.org>
__NR_Linux_syscalls macro holds the number of system call
exist in mips architecture. We have to change the value of
__NR_Linux_syscalls, if we add or delete a system call.
One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file.
The syscall.tbl file contains the total number of system
calls information. So we have two option to update __NR-
_Linux_syscalls value.
1. Update __NR_Linux_syscalls in asm/unistd.h manually
by counting the no.of system calls. No need to update
__NR_Linux_syscalls until we either add a new system
call or delete existing system call.
2. We can keep this feature it above mentioned script,
that will count the number of syscalls and keep it in
a generated file. In this case we don't need to expli-
citly update __NR_Linux_syscalls in asm/unistd.h file.
The 2nd option will be the recommended one. For that, I
added the __NR_syscalls macro in uapi/asm/unistd.h along
with __NR_Linux_syscalls. The macro __NR_syscalls also
added for making the name convention same across all
architecture. While __NR_syscalls isn't strictly part of
the uapi, having it as part of the generated header to
simplifies the implementation. We also need to enclose
this macro with #ifdef __KERNEL__ to avoid side effects.
Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
arch/mips/include/uapi/asm/unistd.h | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/arch/mips/include/uapi/asm/unistd.h b/arch/mips/include/uapi/asm/unistd.h
index f25dd1d..0ccf954 100644
--- a/arch/mips/include/uapi/asm/unistd.h
+++ b/arch/mips/include/uapi/asm/unistd.h
@@ -391,16 +391,19 @@
#define __NR_rseq (__NR_Linux + 367)
#define __NR_io_pgetevents (__NR_Linux + 368)
+#ifdef __KERNEL__
+#define __NR_syscalls 368
+#endif
/*
* Offset of the last Linux o32 flavoured syscall
*/
-#define __NR_Linux_syscalls 368
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_ABI32 */
#define __NR_O32_Linux 4000
-#define __NR_O32_Linux_syscalls 368
+#define __NR_O32_Linux_syscalls __NR_syscalls
#if _MIPS_SIM == _MIPS_SIM_ABI64
@@ -738,15 +741,19 @@
#define __NR_rseq (__NR_Linux + 327)
#define __NR_io_pgetevents (__NR_Linux + 328)
+#ifdef __KERNEL__
+#define __NR_syscalls 328
+#endif
+
/*
* Offset of the last Linux 64-bit flavoured syscall
*/
-#define __NR_Linux_syscalls 328
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_ABI64 */
#define __NR_64_Linux 5000
-#define __NR_64_Linux_syscalls 328
+#define __NR_64_Linux_syscalls __NR_syscalls
#if _MIPS_SIM == _MIPS_SIM_NABI32
@@ -1088,14 +1095,18 @@
#define __NR_rseq (__NR_Linux + 331)
#define __NR_io_pgetevents (__NR_Linux + 332)
+#ifdef __KERNEL__
+#define __NR_syscalls 332
+#endif
+
/*
* Offset of the last N32 flavoured syscall
*/
-#define __NR_Linux_syscalls 332
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_NABI32 */
#define __NR_N32_Linux 6000
-#define __NR_N32_Linux_syscalls 332
+#define __NR_N32_Linux_syscalls __NR_syscalls
#endif /* _UAPI_ASM_UNISTD_H */
--
1.9.1
next prev parent reply other threads:[~2018-11-15 6:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 6:14 [PATCH v2 0/5] mips: system call table generation support Firoz Khan
2018-11-15 6:14 ` Firoz Khan [this message]
2018-11-19 15:51 ` [PATCH v2 1/5] mips: add __NR_syscalls along with __NR_Linux_syscalls Arnd Bergmann
2018-11-20 6:42 ` Firoz Khan
2018-11-15 6:14 ` [PATCH v2 2/5] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-11-19 15:57 ` Arnd Bergmann
2018-11-15 6:14 ` [PATCH v2 3/5] mips: remove syscall table entries Firoz Khan
2018-11-19 22:29 ` Paul Burton
2018-11-20 10:54 ` Arnd Bergmann
2018-11-15 6:14 ` [PATCH v2 4/5] mips: add system call table generation support Firoz Khan
2018-11-19 16:00 ` Arnd Bergmann
2018-11-19 22:35 ` Paul Burton
2018-11-20 7:13 ` Firoz Khan
2018-11-15 6:14 ` [PATCH v2 5/5] mips: generate uapi header and system call table files Firoz Khan
2018-11-19 16:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542262461-29024-2-git-send-email-firoz.khan@linaro.org \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul.burton@mips.com \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).