From: osalvador <osalvador@suse.de>
To: Dan Williams <dan.j.williams@intel.com>, osalvador@techadventures.net
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Michal Hocko" <mhocko@suse.com>,
"Yasuaki Ishimatsu" <yasu.isimatu@gmail.com>,
rppt@linux.vnet.ibm.com, malat@debian.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Pasha Tatashin" <pavel.tatashin@microsoft.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
Jonathan.Cameron@huawei.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
"David Hildenbrand" <david@redhat.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Linux MM" <linux-mm@kvack.org>,
alexander.h.duyck@linux.intel.com
Subject: Re: [PATCH 2/5] mm/memory_hotplug: Create add/del_device_memory functions
Date: Fri, 16 Nov 2018 14:03:53 +0100 [thread overview]
Message-ID: <1542373433.3020.19.camel@suse.de> (raw)
In-Reply-To: <CAPcyv4jM-EJCmOwFkPqXhtgR54UueNtHjfCUbnnJqFLmgj7Jvw@mail.gmail.com>
> This collides with the refactoring of hmm, to be done in terms of
> devm_memremap_pages(). I'd rather not introduce another common
> function *beneath* hmm and devm_memremap_pages() and rather make
> devm_memremap_pages() the common function.
Hi Dan,
That is true.
Previous version of this patchet was based on yours (hmm-refactor),
but then I decided to not base it here due to lack of feedback.
But if devm_memremap_pages() is going to be the main/common function,
I am totally fine to put the memory-hotplug specific there.
> I plan to resubmit that cleanup after Plumbers. So, unless I'm
> misunderstanding some other benefit a nak from me on this patch as it
> stands currently.
Great, then I will wait for your new patchset, and then I will base
this one on that.
Thanks
Oscar Salvador
next prev parent reply other threads:[~2018-11-16 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 15:30 [PATCH 0/5] Do not touch pages/zones during hot-remove path Oscar Salvador
2018-10-15 15:30 ` [PATCH 1/5] mm/memory_hotplug: Add nid parameter to arch_remove_memory Oscar Salvador
2018-11-12 18:52 ` Pavel Tatashin
2018-10-15 15:30 ` [PATCH 2/5] mm/memory_hotplug: Create add/del_device_memory functions Oscar Salvador
2018-10-16 8:55 ` David Hildenbrand
2018-10-17 9:33 ` Oscar Salvador
2018-10-17 9:45 ` David Hildenbrand
2018-10-18 6:57 ` Oscar Salvador
2018-11-12 19:14 ` Pavel Tatashin
2018-11-12 19:21 ` Dan Williams
2018-11-12 21:28 ` Pavel Tatashin
2018-11-16 13:06 ` osalvador
2018-11-16 13:03 ` osalvador [this message]
2018-10-15 15:30 ` [PATCH 3/5] mm/memory_hotplug: Check for IORESOURCE_SYSRAM in release_mem_region_adjustable Oscar Salvador
2018-10-16 9:54 ` David Hildenbrand
2018-11-12 19:27 ` Pavel Tatashin
2018-10-15 15:30 ` [PATCH 4/5] mm/memory_hotplug: Move zone/pages handling to offline stage Oscar Salvador
2018-10-15 15:30 ` [PATCH 5/5] mm/memory-hotplug: Rework unregister_mem_sect_under_nodes Oscar Salvador
2018-10-18 14:24 ` Jonathan Cameron
2018-10-18 15:02 ` Oscar Salvador
2018-10-18 15:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542373433.3020.19.camel@suse.de \
--to=osalvador@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mhocko@suse.com \
--cc=osalvador@techadventures.net \
--cc=pavel.tatashin@microsoft.com \
--cc=rafael@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).