From: Doug Berger <opendmb@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
YueHaibing <yuehaibing@huawei.com>,
Doug Berger <opendmb@gmail.com>
Subject: [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend
Date: Mon, 19 Nov 2018 09:56:00 -0800 [thread overview]
Message-ID: <1542650162-9229-1-git-send-email-opendmb@gmail.com> (raw)
It is not enough to return an error code from the driver suspend
routine. The driver must also restore the device functionality.
This commit corrects the issue introduced by commit 0db55093b566
("net: bcmgenet: return correct value 'ret' from bcmgenet_power_down")
by calling the driver resume function if the suspend function returns
an error.
Changes in v2:
- Removed accidentally included write to HFB register
Doug Berger (2):
net: bcmgenet: code movement
net: bcmgenet: abort suspend on error
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 63 +++++++++++-----------
drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c | 2 +
2 files changed, 35 insertions(+), 30 deletions(-)
--
2.7.4
next reply other threads:[~2018-11-19 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 17:56 Doug Berger [this message]
2018-11-19 17:56 ` [PATCH net-next v2 1/2] net: bcmgenet: code movement Doug Berger
2018-11-19 17:56 ` [PATCH net-next v2 2/2] net: bcmgenet: abort suspend on error Doug Berger
2018-11-20 2:43 ` [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542650162-9229-1-git-send-email-opendmb@gmail.com \
--to=opendmb@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).