From: NeilBrown <neilb@suse.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Martin Wilck <mwilck@suse.de>,
linux-fsdevel@vger.kernel.org,
Frank Filz <ffilzlnx@mindspring.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 04/12] gfs2: properly initial file_lock used for unlock.
Date: Fri, 30 Nov 2018 10:04:08 +1100 [thread overview]
Message-ID: <154353264837.32133.3701953928194212665.stgit@noble> (raw)
In-Reply-To: <154353251599.32133.1085882002675619240.stgit@noble>
Rather than assuming all-zeros is sufficient, use the available API to
initialize the file_lock structure use for unlock. VFS-level changes
will soon make it important that the list_heads in file_lock are
always properly initialized.
Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: J. Bruce Fields <bfields@redhat.com>
---
fs/gfs2/file.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 45a17b770d97..a2dea5bc0427 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -1199,13 +1199,13 @@ static int do_flock(struct file *file, int cmd, struct file_lock *fl)
mutex_lock(&fp->f_fl_mutex);
if (gfs2_holder_initialized(fl_gh)) {
+ struct file_lock request;
if (fl_gh->gh_state == state)
goto out;
- locks_lock_file_wait(file,
- &(struct file_lock) {
- .fl_type = F_UNLCK,
- .fl_flags = FL_FLOCK
- });
+ locks_init_lock(&request);
+ request.fl_type = F_UNLCK;
+ request.fl_flags = FL_FLOCK;
+ locks_lock_file_wait(file, &request);
gfs2_glock_dq(fl_gh);
gfs2_holder_reinit(state, flags, fl_gh);
} else {
next prev parent reply other threads:[~2018-11-29 23:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:04 [PATCH 00/12 v6] fs/locks: avoid thundering-herd wake-ups NeilBrown
2018-11-29 23:04 ` [PATCH 12/12] fs/locks: remove unnecessary white space NeilBrown
2018-11-29 23:04 ` [PATCH 06/12] fs/locks: use properly initialized file_lock when unlocking NeilBrown
2018-11-29 23:04 ` [PATCH 05/12] ocfs2: properly initial file_lock used for unlock NeilBrown
2018-11-29 23:04 ` [PATCH 10/12] fs/locks: create a tree of dependent requests NeilBrown
2018-11-29 23:04 ` [PATCH 03/12] NFS: use locks_copy_lock() to copy locks NeilBrown
2018-11-29 23:04 ` [PATCH 07/12] fs/locks: allow a lock request to block other requests NeilBrown
2018-11-29 23:04 ` [PATCH 09/12] fs/locks: change all *_conflict() functions to return bool NeilBrown
2018-11-29 23:04 ` NeilBrown [this message]
2018-11-29 23:04 ` [PATCH 08/12] fs/locks: always delete_block after waiting NeilBrown
2018-11-29 23:04 ` [PATCH 02/12] fs/locks: split out __locks_wake_up_blocks() NeilBrown
2018-11-29 23:04 ` [PATCH 11/12] fs/locks: merge posix_unblock_lock() and locks_delete_block() NeilBrown
2018-11-29 23:04 ` [PATCH 01/12] fs/locks: rename some lists and pointers NeilBrown
2018-11-30 16:34 ` [PATCH 00/12 v6] fs/locks: avoid thundering-herd wake-ups Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 1:14 [PATCH 00/12 v5] locks: " NeilBrown
2018-11-12 1:14 ` [PATCH 04/12] gfs2: properly initial file_lock used for unlock NeilBrown
2018-11-05 1:30 [PATCH 00/12] Series short description NeilBrown
2018-11-05 1:30 ` [PATCH 04/12] gfs2: properly initial file_lock used for unlock NeilBrown
2018-11-05 12:18 ` Jeff Layton
2018-11-06 1:48 ` NeilBrown
2018-11-06 13:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154353264837.32133.3701953928194212665.stgit@noble \
--to=neilb@suse.com \
--cc=bfields@fieldses.org \
--cc=ffilzlnx@mindspring.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwilck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).