From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Nicholas Mc Guire <hofrat@osadl.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
Rob Herring <robh@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: Re: [PATCH V2] clk: zynq: do not allow kmalloc failure
Date: Thu, 29 Nov 2018 15:45:23 -0800 [thread overview]
Message-ID: <154353512315.88331.4548631955021366823@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1542803310-32673-1-git-send-email-hofrat@osadl.org>
Quoting Nicholas Mc Guire (2018-11-21 04:28:30)
> The kmalloc here is small (< 16 bytes) and occurs during initialization
> during system startup here (can not be built as module) thus if this
> kmalloc failed it is an indication of something more serious going on
> and it is fine to hang the system here rather than cause some harder
> to understand error by dereferencing NULL.
>
> Explicitly checking would not make that much sense here as the only
> possible reaction would be would BUG() here anyway.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: 0ee52b157b8e ("clk: zynq: Add clock controller driver")
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
Nak. We don't have any __GFP_NOFAIL in drivers/clk and I don't see a
reason why we would want it here either. Just handle the failure, or
don't care if this is so critical to system boot.
next prev parent reply other threads:[~2018-11-29 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 12:28 [PATCH V2] clk: zynq: do not allow kmalloc failure Nicholas Mc Guire
2018-11-29 23:45 ` Stephen Boyd [this message]
2018-11-30 7:54 ` Nicholas Mc Guire
2018-11-30 8:09 ` Stephen Boyd
2018-11-30 8:29 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154353512315.88331.4548631955021366823@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=hofrat@osadl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).