From: Stephen Boyd <sboyd@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-arm-msm@vger.kernel.org, Taniya Das <tdas@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: Require #reset-cells in sdm845-videocc
Date: Fri, 30 Nov 2018 01:01:35 -0800 [thread overview]
Message-ID: <154356849500.88331.9932899465368459791@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181127192443.136158-1-dianders@chromium.org>
Quoting Douglas Anderson (2018-11-27 11:24:43)
> The #reset-cells was listed as optional in the bindings for
> qcom,sdm845-videocc. There's no reason for it to be optional. As per
> Stephen [1]:
>
> > We should update the binding to make it a required property. It
> > doesn't make any sense why that property would be optional given
> > that the hardware either has support for resets or it doesn't.
>
> sdm845 support is still in its infancy so we shouldn't be affecting
> any real device trees by modifying the bindings here.
>
> [1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com
>
> Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings")
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Applied to clk-next
prev parent reply other threads:[~2018-11-30 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 19:24 [PATCH] dt-bindings: clock: Require #reset-cells in sdm845-videocc Douglas Anderson
2018-11-30 9:01 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154356849500.88331.9932899465368459791@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).