From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <andy.gross@linaro.org>,
Evan Green <evgreen@chromium.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Evan Green <evgreen@chromium.org>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child
Date: Mon, 03 Dec 2018 14:37:24 -0800 [thread overview]
Message-ID: <154387664448.88331.2728522404504674597@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181129221357.67417-2-evgreen@chromium.org>
Quoting Evan Green (2018-11-29 14:13:54)
> The phy-qcom-qmp bindings specified #clock-cells as 1. This was never used
> because of_clk_add_provider() was never called, so there was no way anybody
> could reference these clocks from DT. Furthermore, even if they could be
> accessed, the bindings never specified what should go in that additional
> cell.
>
> Fix these incomplete and broken bindings. Move the #clock-cells into the
> child node, since that is the actual clock provider, and not all
> instances of qcom-qmp-phy are clock providers. Also set #clock-cells to
> zero, since there's nothing to pass to it.
>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2018-12-03 22:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 22:13 [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider Evan Green
2018-11-29 22:13 ` [PATCH v1 1/4] dt-bindings: phy-qcom-qmp: Move #clock-cells to child Evan Green
2018-12-03 22:37 ` Stephen Boyd [this message]
2018-11-29 22:13 ` [PATCH v1 2/4] arm64: dts: qcom: msm8996: Fix QMP PHY #clock-cells Evan Green
2018-12-03 22:37 ` Stephen Boyd
2018-12-07 8:32 ` Vivek Gautam
2018-11-29 22:13 ` [PATCH v1 3/4] arm64: dts: qcom: sdm845: " Evan Green
2018-12-03 22:37 ` Stephen Boyd
2018-11-29 22:13 ` [PATCH v1 4/4] phy: qcom-qmp: Expose provided clocks to DT Evan Green
2018-12-03 22:38 ` Stephen Boyd
2018-12-03 23:12 ` Evan Green
2018-12-07 8:34 ` Vivek Gautam
2018-12-04 8:12 ` [PATCH v1 0/4] phy: qcom-qmp: Fix clock-cells binding and provider Kishon Vijay Abraham I
2018-12-04 12:37 ` Vivek Gautam
2018-12-07 4:43 ` Kishon Vijay Abraham I
2018-12-07 6:25 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154387664448.88331.2728522404504674597@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).