From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2ADC04EBF for ; Tue, 4 Dec 2018 19:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58A6E20851 for ; Tue, 4 Dec 2018 19:25:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ljWe3EFK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58A6E20851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbeLDTZR (ORCPT ); Tue, 4 Dec 2018 14:25:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:37778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbeLDTZQ (ORCPT ); Tue, 4 Dec 2018 14:25:16 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2977A206B7; Tue, 4 Dec 2018 19:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543951516; bh=p1VHy5qqvyLZJrku2O0wFxd6wj1gXaTCaZTYqP2k+N0=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=ljWe3EFKzcG8sKAeMSRUnjPCAd85/EvAEfD5kUYSYD99Ubx7Otv7nu+8skMQkzKJW 1PbhAfHR0wB2C0bQFD3tEdgVQbzY1yF61n43gjrA5X+iCJ+ClRfm2GopKYXBRyRB2j E0MqznTsrf9yQZ7UpFH09Z4NNnmp6mXc3WAfAzWo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Jerome Brunet , Jianxin Pan , Neil Armstrong From: Stephen Boyd In-Reply-To: Cc: Yixun Lan , Kevin Hilman , Carlo Caione , Michael Turquette , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1542284312-55418-1-git-send-email-jianxin.pan@amlogic.com> <1542284312-55418-3-git-send-email-jianxin.pan@amlogic.com> <154387713374.88331.16436869339024592009@swboyd.mtv.corp.google.com> Message-ID: <154395151564.88331.17622786431747155066@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v7 2/4] clk: meson: add DT documentation for emmc clock controller Date: Tue, 04 Dec 2018 11:25:15 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jianxin Pan (2018-12-03 18:39:34) > Hi Stephen, > = > On 2018/12/4 6:45, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-11-15 04:18:30) > >> diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h b/include/dt= -bindings/clock/amlogic,mmc-clkc.h > >> new file mode 100644 > >> index 0000000..162b949 > >> --- /dev/null > >> +++ b/include/dt-bindings/clock/amlogic,mmc-clkc.h > >> @@ -0,0 +1,17 @@ > >> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > >> +/* > >> + * Meson MMC sub clock tree IDs > >> + * > >> + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. > >> + * Author: Yixun Lan > >> + */ > >> + > >> +#ifndef __MMC_CLKC_H > >> +#define __MMC_CLKC_H > >> + > >> +#define CLKID_MMC_DIV 1 > > = > > Why does the define numbering start with 1 instead of 0? > > > The Clock ID 0 is used by CLKID_MMC_MUX. > CLKID_MMC_MUX is an internal clock which defined in drivers/clk/meson/mmc= -clkc.c, and it's the parent of CLKID_MMC_DIV. Ok, thanks.