From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F7CC07E85 for ; Wed, 5 Dec 2018 06:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 259532084C for ; Wed, 5 Dec 2018 06:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aMBqqgMo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 259532084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726978AbeLEG5D (ORCPT ); Wed, 5 Dec 2018 01:57:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:48818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbeLEG5C (ORCPT ); Wed, 5 Dec 2018 01:57:02 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 825DE2082B; Wed, 5 Dec 2018 06:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543993021; bh=MXVtmHQq94SWCQYLefz10K5B8VAwOS1nSQUhUkkghzQ=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=aMBqqgMo2okdua5jyGp1OTVc0xbZa9oZyVyyE1FOao0zQyDbbk0D0jN6XPTZ6dJMS O93LRhyYlNR1rSURs1ns6JnnZVC7VE1gnIBcIbD2R7QRzBTK1yMNiaIhIyp7oxG+7S gxmhCzGXmV2xCsZSsYKDEJPrXOa+ckQb8YjwKU1Y= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Masahiro Yamada From: Stephen Boyd In-Reply-To: Cc: sugaya.taichi@socionext.com, DTML , linux-arm-kernel , linux-clk , Linux Kernel Mailing List , linux-serial@vger.kernel.org, Michael Turquette , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Russell King , Jiri Slaby , Masami Hiramatsu , Jassi Brar References: <1542589274-13878-1-git-send-email-sugaya.taichi@socionext.com> <1542589274-13878-8-git-send-email-sugaya.taichi@socionext.com> <154356669840.88331.4455990896653868594@swboyd.mtv.corp.google.com> <154394724886.88331.4940706362054124931@swboyd.mtv.corp.google.com> Message-ID: <154399302077.88331.14221169169421246205@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control Date: Tue, 04 Dec 2018 22:57:00 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Masahiro Yamada (2018-12-04 20:26:06) > On Wed, Dec 5, 2018 at 3:14 AM Stephen Boyd wrote: > > > > Quoting Masahiro Yamada (2018-12-04 03:03:53) > > > Hi Stephen, > > > > > > > > > On Fri, Nov 30, 2018 at 5:31 PM Stephen Boyd wrote: > > > > > > > > Quoting Sugaya Taichi (2018-11-18 17:01:12) > > > > > Add Milbeaut M10V clock ( including PLL ) control. > > > > > > > > Please give some more details here. > > > > > > > > > > > > > > Signed-off-by: Sugaya Taichi > > > > > --- > > > > > drivers/clk/Makefile | 1 + > > > > > drivers/clk/clk-m10v.c | 671 +++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > > > > > > And this is different from Uniphier? Maybe we need a socionext > > > > directory under drivers/clk/. > > > > > > > > > > > > This is always a difficult question, > > > and I do not have a strong opinion. > > > > > > > > > I am fine with moving the files to drivers/clk/socionext > > > although no file would be shared. > > > > > > > > > FYI > > > > > > UniPhier and Milbeaut are completely different platforms > > > developed/maintained by different teams. > > > > > > They happen to live in the same company now > > > just because Socionext merged the LSI business from Panasonic and Fuj= itsu. > > > > > > UniPhier originates in Panasonic, while Milbeaut in Fujitsu. > > > > > > > Thanks for the background info. I'd prefer to defer to however the dts > > files are getting split up into directories. If they're all put under > > arch/arm64/boot/dts/socionext/ then I would say combine the two clk > > drivers into a socionext directory. Otherwise, keep them split out. > = > = > If you want to align with the DT directory structure, > the answer is clear. > = > = > Milbeaut DT files will be put together with UniPhier ones > into socionext directory. > = > = > For arm64, DT directories are already sorted out by vendors. > = > Even 32-bit ARM is going to that way. > = > Rob Herring just posted a python script > to move all DT files in arch/arm/boot/dts/ > into vendor subdirectories. > = > = > Please let me know if you want me to > move drivers/clk/uniphier/* to drivers/clk/socionext/*. > = Maybe the dts needs to be split up instead? Looks like the gpio drivers are in a uniphier directory and there is some precedence to keep the "taken over" company name when vendors are merged into other vendors. Maybe that's how things have happened here? It would be nice to be consistent, but I leave the decision up to you to figure out if that really matters to you. I'll be fine either way.