From: Roger Quadros <rogerq@ti.com>
To: <balbi@kernel.org>
Cc: <tony@atomide.com>, <robh+dt@kernel.org>, <nsekhar@ti.com>,
<t-kristo@ti.com>, <vigneshr@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<rogerq@ti.com>
Subject: [PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded
Date: Wed, 5 Dec 2018 17:19:29 +0200 [thread overview]
Message-ID: <1544023171-5796-2-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1544023171-5796-1-git-send-email-rogerq@ti.com>
On v3.10a in dual-role mode, if port is in device mode
and gadget driver isn't loaded, the OTG event interrupts don't
come through.
It seems that if the core is configured to be OTG2.0 only,
then we can't leave the DCFG.DEVSPD at Super-speed (default)
if we expect OTG to work properly. It must be set to High-speed.
Fix this issue by configuring DCFG.DEVSPD to the supported
maximum speed at gadget init. Device tree still needs to provide
correct supported maximum speed for this to work.
This issue wasn't present on v2.40a but is seen on v3.10a.
It doesn't cause any side effects on v2.40a.
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
drivers/usb/dwc3/gadget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 679c12e..79120c0 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -3240,6 +3240,8 @@ int dwc3_gadget_init(struct dwc3 *dwc)
goto err4;
}
+ dwc3_gadget_set_speed(&dwc->gadget, dwc->maximum_speed);
+
return 0;
err4:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-12-05 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 15:19 [PATCH 0/3] usb: dwc3: Add support for AM654 USB Roger Quadros
2018-12-05 15:19 ` Roger Quadros [this message]
2018-12-05 15:19 ` [PATCH 2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support Roger Quadros
2018-12-06 10:32 ` Vignesh R
2018-12-10 9:05 ` Roger Quadros
2018-12-05 15:19 ` [PATCH 3/3] usb: dwc3: keystone: Add support for ti,am654-dwc3 Roger Quadros
-- strict thread matches above, loose matches on Subject: below --
2018-12-05 15:14 [PATCH 0/3] usb: dwc3: Add support for AM654 USB Roger Quadros
2018-12-05 15:14 ` [PATCH 1/3] usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544023171-5796-2-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).