From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S947542AbdDTVH3 (ORCPT ); Thu, 20 Apr 2017 17:07:29 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51733 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947454AbdDTVHZ (ORCPT ); Thu, 20 Apr 2017 17:07:25 -0400 From: Thiago Jung Bauermann To: David Howells Cc: Mimi Zohar , linux-security-module@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Kasatkin , Herbert Xu , "David S. Miller" , Claudio Carvalho Subject: Re: [PATCH 5/6] MODSIGN: Export module signature definitions. Date: Thu, 20 Apr 2017 18:07:15 -0300 User-Agent: KMail/5.2.3 (Linux/4.4.0-72-generic; KDE/5.28.0; x86_64; ; ) In-Reply-To: <21102.1492699057@warthog.procyon.org.uk> References: <1492691712.3081.85.camel@linux.vnet.ibm.com> <1492546666-16615-6-git-send-email-bauerman@linux.vnet.ibm.com> <21102.1492699057@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable x-cbid: 17042021-0020-0000-0000-000002A1D7C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042021-0021-0000-0000-000030BEF96A Message-Id: <1544111.Uq9hhXcF4r@morokweng> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-20_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704200199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 20. April 2017, 15:37:37 BRT schrieb David Howells: > Mimi Zohar wrote: > > On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > > > IMA will use the module_signature format for append signatures, so > > > export > > > the relevant definitions and factor out the code which verifies that the > > > appended signature trailer is valid. > > > > > > Also, create a CONFIG_MODULE_SIG_FORMAT option so that IMA can select it > > > and be able to use validate_module_signature without having to depend on > > > CONFIG_MODULE_SIG. > > > > Basically we want to generalize the concept of an appended signature. > > Referring to it as a "module signature format" seems a bit confusing. > > > > David, would you have a problem with changing the appended string from > > "~Module signature appended~\n" to something more generic? > > Conceptually, no. Is it possible that doing so could break someone's module > that they load on multiple versions of the kernel? Say a module that only > exports things and doesn't use anything from the core or any other module. I think that changing the appended string has limited value because very few people actually see them. It's just a marker. We could s/module_signature/ appended_signature/ in the code but keep the actual string unchanged. What do you think? Alternatively, we could change the string but accept both the old and the new string for backwards compatibility. -- Thiago Jung Bauermann IBM Linux Technology Center