From: Qian Cai <cai@gmx.us>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] efi: let kmemleak ignore false positives
Date: Thu, 06 Dec 2018 13:04:59 -0500 [thread overview]
Message-ID: <1544119499.12945.48.camel@gmx.us> (raw)
In-Reply-To: <CAKv+Gu97MU5kU878gF=KBLxQ5GjZatAbJ-LVdKv-QMgdPh3kZQ@mail.gmail.com>
On Thu, 2018-12-06 at 19:01 +0100, Ard Biesheuvel wrote:
> On Thu, 6 Dec 2018 at 19:00, Catalin Marinas <catalin.marinas@arm.com> wrote:
> >
> > On Thu, Dec 06, 2018 at 11:16:33AM -0500, Qian Cai wrote:
> > > unreferenced object 0xffff8096c1acf580 (size 128):
> > > comm "swapper/63", pid 0, jiffies 4294937418 (age 1201.230s)
> > > hex dump (first 32 bytes):
> > > 80 87 b5 c1 96 00 00 00 00 00 cc c2 16 00 00 00 ................
> > > 00 00 01 00 00 00 00 00 6b 6b 6b 6b 6b 6b 6b 6b ........kkkkkkkk
> > > backtrace:
> > > [<000000001d2549ba>] kmem_cache_alloc_trace+0x430/0x500
> > > [<0000000093a6dfab>] efi_mem_reserve_persistent+0x50/0xf8
> > > [<000000000a730828>] its_cpu_init_lpis+0x394/0x4b8
> > > [<00000000edf04e07>] its_cpu_init+0x104/0x150
> > > [<000000004d0342c5>] gic_starting_cpu+0x34/0x40
> > > [<000000005d9da772>] cpuhp_invoke_callback+0x228/0x1d68
> > > [<0000000061eace9b>] notify_cpu_starting+0xc0/0x118
> > > [<0000000048bc2dc5>] secondary_start_kernel+0x23c/0x3b0
> > > [<0000000015137d6a>] 0xffffffffffffffff
> > >
> > > efi_mem_reserve_persistent+0x50/0xf8:
> > > kmalloc at include/linux/slab.h:546
> > > (inlined by) efi_mem_reserve_persistent at drivers/firmware/efi/efi.c:979
> > >
> > > This line,
> > >
> > > rsv = kmalloc(sizeof(*rsv), GFP_ATOMIC);
> > >
> > > Kmemleak has a known limitation that can only track pointers in the kernel
> > > virtual space. Hence, it will report false positives due to "rsv" will
> > > only
> > > reference to other physical addresses,
> > >
> > > rsv->next = efi_memreserve_root->next;
> > > efi_memreserve_root->next = __pa(rsv);
> > >
> > > Signed-off-by: Qian Cai <cai@gmx.us>
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>\
>
> I don't see the patch and I wasn't cc'ed
That is strange. Please see,
https://lore.kernel.org/lkml/1543517152-23969-1-git-send-email-cai@gmx.us/
next prev parent reply other threads:[~2018-12-06 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 18:45 [PATCH] efi: let kmemleak ignore false positives Qian Cai
2018-12-06 16:16 ` [RESEND PATCH] " Qian Cai
2018-12-06 17:59 ` Catalin Marinas
2018-12-06 18:01 ` Ard Biesheuvel
2018-12-06 18:04 ` Qian Cai [this message]
2018-12-07 11:28 ` Ard Biesheuvel
2018-12-07 12:32 ` Qian Cai
2018-12-07 12:45 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544119499.12945.48.camel@gmx.us \
--to=cai@gmx.us \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).