From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Baolin Wang <baolin.wang@linaro.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 4/5] leds: trigger: oneshot: Add initialization from Device Tree
Date: Wed, 12 Dec 2018 12:16:45 +0100 [thread overview]
Message-ID: <1544613406-27026-5-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1544613406-27026-1-git-send-email-krzk@kernel.org>
Allow initialization of delays used in oneshot trigger from Device
Tree property.
This is especially useful for embedded systems where the trigger might
be used early, before bringing up user-space.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
New patch in the series
---
drivers/leds/trigger/ledtrig-oneshot.c | 31 +++++++++++++++++++++++++++++--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/trigger/ledtrig-oneshot.c b/drivers/leds/trigger/ledtrig-oneshot.c
index 95c9be4b6e7e..4e73a1c17a40 100644
--- a/drivers/leds/trigger/ledtrig-oneshot.c
+++ b/drivers/leds/trigger/ledtrig-oneshot.c
@@ -130,6 +130,27 @@ static struct attribute *oneshot_trig_attrs[] = {
};
ATTRIBUTE_GROUPS(oneshot_trig);
+static void pattern_init(struct led_classdev *led_cdev)
+{
+ const char *pattern;
+ unsigned long delay_on, delay_off;
+
+ pattern = led_classdev_get_default_pattern(led_cdev);
+ if (!pattern) {
+ led_cdev->blink_delay_on = DEFAULT_DELAY;
+ led_cdev->blink_delay_off = DEFAULT_DELAY;
+ return;
+ }
+
+ if (sscanf(pattern, "%lu %lu", &delay_on, &delay_off) == 2) {
+ led_cdev->blink_delay_on = delay_on;
+ led_cdev->blink_delay_off = delay_off;
+ } else {
+ dev_warn(led_cdev->dev,
+ "Invalid value for delays pattern\n");
+ }
+}
+
static int oneshot_trig_activate(struct led_classdev *led_cdev)
{
struct oneshot_trig_data *oneshot_data;
@@ -140,8 +161,14 @@ static int oneshot_trig_activate(struct led_classdev *led_cdev)
led_set_trigger_data(led_cdev, oneshot_data);
- led_cdev->blink_delay_on = DEFAULT_DELAY;
- led_cdev->blink_delay_off = DEFAULT_DELAY;
+ if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER) {
+ pattern_init(led_cdev);
+ /*
+ * Mark as initialized even on pattern_init() error because
+ * any consecutive call to it would produce the same error.
+ */
+ led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
+ }
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2018-12-12 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:16 [PATCH v3 0/5] leds: trigger: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-12 11:16 ` [PATCH v3 1/5] dt-bindings: leds: " Krzysztof Kozlowski
2018-12-12 12:32 ` Pavel Machek
2018-12-13 8:36 ` Krzysztof Kozlowski
2018-12-17 22:40 ` Rob Herring
2018-12-18 9:06 ` Krzysztof Kozlowski
2018-12-12 11:16 ` [PATCH v3 2/5] leds: Add helper for getting default pattern " Krzysztof Kozlowski
2018-12-12 12:22 ` Pavel Machek
2018-12-13 8:21 ` Krzysztof Kozlowski
2018-12-12 11:16 ` [PATCH v3 3/5] leds: trigger: pattern: Add pattern initialization " Krzysztof Kozlowski
2018-12-12 11:16 ` Krzysztof Kozlowski [this message]
2018-12-12 11:16 ` [PATCH v3 5/5] leds: trigger: timer: Add " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544613406-27026-5-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).