linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>,
	andy.gross@linaro.org, david.brown@linaro.org,
	mturquette@baylibre.com
Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	marc.w.gonzalez@free.fr
Subject: Re: [PATCH v2] clk: qcom: Drop unused 8998 clock
Date: Thu, 13 Dec 2018 17:32:58 -0800	[thread overview]
Message-ID: <154475117840.19322.15245180996092285862@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <d7ac2e27-8e9e-7ee1-430d-ed0f61d98171@codeaurora.org>

Quoting Jeffrey Hugo (2018-12-13 14:32:12)
> On 12/13/2018 12:38 PM, Stephen Boyd wrote:
> > Quoting Jeffrey Hugo (2018-12-13 09:09:09)
> >> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> >> expect it to be needed for clients.  Let's remove it because messing with
> >> the clock has been observed to cause Linux hangs when the qdss_clk is
> >> initialized by rpmcc.
> >>
> >> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> >> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> >> ---
> >>
> >> v2:
> >> -corrected commit text per Marc
> >> -added Marc's reviewed-by
> > 
> > Please slow down. There isn't any need to resend for such things.
> > 
> 
> Sorry.  Used to other maintainers.
>  From your v1 comment, would be
> Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support)
> I'm assuming from the above, you'll just apply the tag when you apply 
> the change.
> 

Hmm I already marked it as 'changes requested' but OK, I can pick it up
and add the fixes tag now.


  reply	other threads:[~2018-12-14  1:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 17:09 [PATCH v2] clk: qcom: Drop unused 8998 clock Jeffrey Hugo
2018-12-13 19:38 ` Stephen Boyd
2018-12-13 22:32   ` Jeffrey Hugo
2018-12-14  1:32     ` Stephen Boyd [this message]
2018-12-14 21:42 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154475117840.19322.15245180996092285862@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).