From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Raphael Teysseyre <rteysseyre@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Baolin Wang <baolin.wang@linaro.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v4 5/5] leds: trigger: timer: Add initialization from Device Tree
Date: Tue, 18 Dec 2018 16:27:32 +0100 [thread overview]
Message-ID: <1545146852-32207-6-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1545146852-32207-1-git-send-email-krzk@kernel.org>
Allow initialization of delays used in timer trigger from Device
Tree property.
This is especially useful for embedded systems where the trigger might
be used early, before bringing up user-space.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/leds/trigger/ledtrig-timer.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/leds/trigger/ledtrig-timer.c b/drivers/leds/trigger/ledtrig-timer.c
index 7c14983781ee..3c253241cfa6 100644
--- a/drivers/leds/trigger/ledtrig-timer.c
+++ b/drivers/leds/trigger/ledtrig-timer.c
@@ -15,6 +15,7 @@
#include <linux/init.h>
#include <linux/device.h>
#include <linux/ctype.h>
+#include <linux/slab.h>
#include <linux/leds.h>
static ssize_t led_delay_on_show(struct device *dev,
@@ -77,8 +78,41 @@ static struct attribute *timer_trig_attrs[] = {
};
ATTRIBUTE_GROUPS(timer_trig);
+static void pattern_init(struct led_classdev *led_cdev)
+{
+ u32 *pattern;
+ unsigned int size = 0;
+
+ pattern = led_classdev_get_default_pattern(led_cdev, &size);
+ if (!pattern)
+ return;
+
+ if (size != 2) {
+ dev_warn(led_cdev->dev,
+ "Expected 2 but got %u values for delays pattern\n",
+ size);
+ goto out;
+ }
+
+ led_cdev->blink_delay_on = pattern[0];
+ led_cdev->blink_delay_off = pattern[1];
+ /* led_blink_set() called by caller */
+
+out:
+ kfree(pattern);
+}
+
static int timer_trig_activate(struct led_classdev *led_cdev)
{
+ if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER) {
+ pattern_init(led_cdev);
+ /*
+ * Mark as initialized even on pattern_init() error because
+ * any consecutive call to it would produce the same error.
+ */
+ led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
+ }
+
led_blink_set(led_cdev, &led_cdev->blink_delay_on,
&led_cdev->blink_delay_off);
--
2.7.4
prev parent reply other threads:[~2018-12-18 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 15:27 [PATCH v4 0/5] leds: trigger: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 1/5] dt-bindings: leds: " Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 2/5] leds: Add helper for getting default pattern " Krzysztof Kozlowski
2018-12-27 8:47 ` Krzysztof Kozlowski
2018-12-27 19:29 ` Jacek Anaszewski
2018-12-18 15:27 ` [PATCH v4 3/5] leds: trigger: pattern: Add pattern initialization " Krzysztof Kozlowski
2018-12-18 15:27 ` [PATCH v4 4/5] leds: trigger: oneshot: Add " Krzysztof Kozlowski
2018-12-18 15:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545146852-32207-6-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).