From: "huang.zijiang" <huang.zijiang@zte.com.cn>
To: akpm@linux-foundation.org
Cc: rppt@linux.vnet.ibm.com, mhocko@suse.com, sfr@canb.auug.org.au,
mpe@ellerman.id.au, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn,
"huang.zijiang" <huang.zijiang@zte.com.cn>
Subject: [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic
Date: Mon, 24 Dec 2018 16:41:22 +0800 [thread overview]
Message-ID: <1545640882-42009-1-git-send-email-huang.zijiang@zte.com.cn> (raw)
From: "huang.zijiang" <huang.zijiang@zte.com.cn>
memblock_alloc never returns NULL because panic never returns
Signed-off-by: huang.zijiang <huang.zijiang@zte.com.cn>
---
drivers/firmware/memmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
index d168c87..ec4fd25 100644
--- a/drivers/firmware/memmap.c
+++ b/drivers/firmware/memmap.c
@@ -333,7 +333,7 @@ int __init firmware_map_add_early(u64 start, u64 end, const char *type)
{
struct firmware_map_entry *entry;
- entry = memblock_alloc(sizeof(struct firmware_map_entry),
+ entry = memblock_alloc_nopanic(sizeof(struct firmware_map_entry),
SMP_CACHE_BYTES);
if (WARN_ON(!entry))
return -ENOMEM;
--
1.8.3.1
next reply other threads:[~2018-12-24 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 8:41 huang.zijiang [this message]
2018-12-24 12:14 ` [PATCH] firmware/memmap:Modify memblock_alloc to memblock_alloc_nopanic Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545640882-42009-1-git-send-email-huang.zijiang@zte.com.cn \
--to=huang.zijiang@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).