* [PATCH 2/2] arm/plat-pxa/ssp : unneeded to free devm_ allocated data
@ 2018-12-29 5:10 Peng Hao
2019-01-03 21:06 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: Peng Hao @ 2018-12-29 5:10 UTC (permalink / raw)
To: linux, robert.jarzmik; +Cc: linux-arm-kernel, linux-kernel, Peng Hao
devm_ allocated data will be automatically freed. The free
of devm_ allocated data is invalid.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
arch/arm/plat-pxa/ssp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c
index ed36dca..f519199 100644
--- a/arch/arm/plat-pxa/ssp.c
+++ b/arch/arm/plat-pxa/ssp.c
@@ -190,8 +190,6 @@ static int pxa_ssp_remove(struct platform_device *pdev)
if (ssp == NULL)
return -ENODEV;
- iounmap(ssp->mmio_base);
-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
@@ -201,7 +199,6 @@ static int pxa_ssp_remove(struct platform_device *pdev)
list_del(&ssp->node);
mutex_unlock(&ssp_lock);
- kfree(ssp);
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] arm/plat-pxa/ssp : unneeded to free devm_ allocated data
2018-12-29 5:10 [PATCH 2/2] arm/plat-pxa/ssp : unneeded to free devm_ allocated data Peng Hao
@ 2019-01-03 21:06 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2019-01-03 21:06 UTC (permalink / raw)
To: Peng Hao, linux; +Cc: linux-kernel, linux-arm-kernel
Peng Hao <peng.hao2@zte.com.cn> writes:
> devm_ allocated data will be automatically freed. The free
> of devm_ allocated data is invalid.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Hi Peng Hao,
Thanks for the patch. I changed your title to fit my tree, ie. :
"ARM: pxa: ssp: unneeded to free devm_ allocated data"
If you have other patches please check what is the commit subject's prefix for
the file(s) you're touching.
Queued to pxa/fixes.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-03 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-29 5:10 [PATCH 2/2] arm/plat-pxa/ssp : unneeded to free devm_ allocated data Peng Hao
2019-01-03 21:06 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).