From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7099AC433F5 for ; Wed, 30 Mar 2022 16:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349077AbiC3Q4F (ORCPT ); Wed, 30 Mar 2022 12:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235540AbiC3Q4A (ORCPT ); Wed, 30 Mar 2022 12:56:00 -0400 Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FE8E13DE2; Wed, 30 Mar 2022 09:54:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 1650A2838F5; Wed, 30 Mar 2022 12:54:14 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id INgx71j7V384; Wed, 30 Mar 2022 12:54:13 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 991612837F8; Wed, 30 Mar 2022 12:54:13 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 991612837F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1648659253; bh=vBhdBJ7dHZ28+lgeKrRzaznue2psKCAuHmp24VjvHtM=; h=Date:From:To:Message-ID:MIME-Version; b=khuM6+RvN2+2Xnf1a8i3R7S2FKDHzZoT9L3DKIevMYbTz1d3luWfpOT49d+ykn+8x cZt+2rIFSNGIaNlR/9LT3+CDLS0vujSzRxD6mY5c4vS4jBuXwTlbRT+v6F+Fznluw6 15crOi0vMumCCR3+pIoIcMWG8oHZhAp4NZjJ0SCTzDoBZpdlGgg+vPngTz81Si6zQf 1rvCJa36jHMUKHXPYIMSJ4YGiImxnezEcBD4IVYkis9rxeR1DUw5TyoU8hYBJ5u/Qp oJaT9HY4eqPjeP8+xNjFjf6RKb1B9741aqjNw6cmzqwPnQW9lEHxvbBLgsHdwCHc7M oiWfLwA8UgwLw== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ekmNHHteiH6J; Wed, 30 Mar 2022 12:54:13 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 8674A283B0E; Wed, 30 Mar 2022 12:54:13 -0400 (EDT) Date: Wed, 30 Mar 2022 12:54:13 -0400 (EDT) From: Mathieu Desnoyers To: rostedt Cc: linux-kernel , Beau Belgrave , Masami Hiramatsu , linux-trace-devel , bpf , netdev , Alexei Starovoitov , Linus Torvalds Message-ID: <1546405229.199729.1648659253425.JavaMail.zimbra@efficios.com> In-Reply-To: <20220329222514.51af6c07@gandalf.local.home> References: <20220329222514.51af6c07@gandalf.local.home> Subject: Re: [PATCH] tracing: Set user_events to BROKEN MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4203 (ZimbraWebClient - FF98 (Linux)/8.8.15_GA_4232) Thread-Topic: tracing: Set user_events to BROKEN Thread-Index: 5jQbENgLvFWNlihIx8tKdfIg6R13sQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Mar 29, 2022, at 10:25 PM, rostedt rostedt@goodmis.org wrote: > From: "Steven Rostedt (Google)" > > After being merged, user_events become more visible to a wider audience > that have concerns with the current API. It is too late to fix this for > this release, but instead of a full revert, just mark it as BROKEN (which > prevents it from being selected in make config). Then we can work finding > a better API. If that fails, then it will need to be completely reverted. Hi Steven, What are the constraints for changing a uapi header after it has been present in a kernel release ? If we are not ready to commit to an ABI, perhaps it would be safer to ensure that include/uapi/linux/user_events.h is not installed with the uapi headers until it's ready. Thanks, Mathieu > > Link: > https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.zimbra@efficios.com/ > > Signed-off-by: Steven Rostedt (Google) > --- > kernel/trace/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 16a52a71732d..edc8159f63ef 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -741,6 +741,7 @@ config USER_EVENTS > bool "User trace events" > select TRACING > select DYNAMIC_EVENTS > + depends on BROKEN # API needs to be straighten out > help > User trace events are user-defined trace events that > can be used like an existing kernel trace event. User trace > -- > 2.35.1 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com