* [PATCH 1/2] mailbox: stm32-ipcc: do not enable wakeup source by default
@ 2019-01-04 13:47 Fabien Dessenne
2019-01-04 13:47 ` [PATCH 2/2] mailbox: stm32-ipcc: remove useless device_init_wakeup call Fabien Dessenne
0 siblings, 1 reply; 2+ messages in thread
From: Fabien Dessenne @ 2019-01-04 13:47 UTC (permalink / raw)
To: Jassi Brar, Maxime Coquelin, Alexandre Torgue, linux-kernel,
linux-stm32, linux-arm-kernel
Cc: Benjamin Gaignard, Arnaud Pouliquen, Ludovic Barre
By default do not enable the wakeup source.
This lets the userspace application decide whether the wakeup source
shall be enabled or not.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/mailbox/stm32-ipcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
index a338bd4..7ca8a14 100644
--- a/drivers/mailbox/stm32-ipcc.c
+++ b/drivers/mailbox/stm32-ipcc.c
@@ -270,7 +270,7 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
goto err_clk;
}
- device_init_wakeup(dev, true);
+ device_set_wakeup_capable(dev, true);
ret = dev_pm_set_dedicated_wake_irq(dev, ipcc->wkp);
if (ret) {
dev_err(dev, "Failed to set wake up irq\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] mailbox: stm32-ipcc: remove useless device_init_wakeup call
2019-01-04 13:47 [PATCH 1/2] mailbox: stm32-ipcc: do not enable wakeup source by default Fabien Dessenne
@ 2019-01-04 13:47 ` Fabien Dessenne
0 siblings, 0 replies; 2+ messages in thread
From: Fabien Dessenne @ 2019-01-04 13:47 UTC (permalink / raw)
To: Jassi Brar, Maxime Coquelin, Alexandre Torgue, linux-kernel,
linux-stm32, linux-arm-kernel
Cc: Benjamin Gaignard, Arnaud Pouliquen, Ludovic Barre
If the "wakeup-source" property does not exist there is no need to call
device_init_wakeup("false") at probe.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/mailbox/stm32-ipcc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
index 7ca8a14..210fe50 100644
--- a/drivers/mailbox/stm32-ipcc.c
+++ b/drivers/mailbox/stm32-ipcc.c
@@ -276,8 +276,6 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
dev_err(dev, "Failed to set wake up irq\n");
goto err_init_wkp;
}
- } else {
- device_init_wakeup(dev, false);
}
/* mailbox controller */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-04 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 13:47 [PATCH 1/2] mailbox: stm32-ipcc: do not enable wakeup source by default Fabien Dessenne
2019-01-04 13:47 ` [PATCH 2/2] mailbox: stm32-ipcc: remove useless device_init_wakeup call Fabien Dessenne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).