* [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header
@ 2019-01-10 7:33 Sabyasachi Gupta
2019-01-10 7:41 ` Oliver Neukum
0 siblings, 1 reply; 2+ messages in thread
From: Sabyasachi Gupta @ 2019-01-10 7:33 UTC (permalink / raw)
To: stern, gregkh
Cc: jrdr.linux, linux-usb, usb-storage, linux-kernel, brajeswar.linux
Remove unusual_jumpshot.h which is included more than once.
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
drivers/usb/storage/jumpshot.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
index 917f170..06e46c6 100644
--- a/drivers/usb/storage/jumpshot.c
+++ b/drivers/usb/storage/jumpshot.c
@@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
}
static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
-# include "unusual_jumpshot.h"
{ } /* Terminating entry */
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header
2019-01-10 7:33 [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header Sabyasachi Gupta
@ 2019-01-10 7:41 ` Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2019-01-10 7:41 UTC (permalink / raw)
To: Sabyasachi Gupta, gregkh, stern
Cc: brajeswar.linux, jrdr.linux, usb-storage, linux-kernel, linux-usb
On Do, 2019-01-10 at 13:03 +0530, Sabyasachi Gupta wrote:
> Remove unusual_jumpshot.h which is included more than once.
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/usb/storage/jumpshot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
> index 917f170..06e46c6 100644
> --- a/drivers/usb/storage/jumpshot.c
> +++ b/drivers/usb/storage/jumpshot.c
> @@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
> }
>
> static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
> -# include "unusual_jumpshot.h"
> { } /* Terminating entry */
> };
>
NACK.
It is included twice because the same device needs to be specified
and is quirky. You are breaking the driver.
Regards
Oliver
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-10 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 7:33 [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header Sabyasachi Gupta
2019-01-10 7:41 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).