From: Long Cheng <long.cheng@mediatek.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Sean Wang <sean.wang@mediatek.com>,
<dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <srv_heupstream@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
"YT Shen" <yt.shen@mediatek.com>,
Zhenbao Liu <zhenbao.liu@mediatek.com>
Subject: Re: [PATCH v9 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support
Date: Thu, 10 Jan 2019 16:50:25 +0800 [thread overview]
Message-ID: <1547110225.3831.24.camel@mhfsdcap03> (raw)
In-Reply-To: <d60c25c2-efe4-9294-dc7e-98f0333bff76@infradead.org>
On Wed, 2019-01-02 at 18:03 -0800, Randy Dunlap wrote:
> Hi,
>
> While you are making changes, here are a few more:
>
hi
OK, thanks for your comments.
>
> On 1/2/19 5:39 PM, Nicolas Boichat wrote:
> > diff --git a/drivers/dma/mediatek/Kconfig b/drivers/dma/mediatek/Kconfig
> > index 27bac0b..1a523c87 100644
> > --- a/drivers/dma/mediatek/Kconfig
> > +++ b/drivers/dma/mediatek/Kconfig
> > @@ -1,4 +1,15 @@
> >
> > +config DMA_MTK_UART
> > + tristate "MediaTek SoCs APDMA support for UART"
> > + depends on OF && SERIAL_8250_MT6577
> > + select DMA_ENGINE
> > + select DMA_VIRTUAL_CHANNELS
> > + help
> > + Support for the UART DMA engine found on MediaTek MTK SoCs.
> > + when SERIAL_8250_MT6577 is enabled, and if you want to use DMA,
>
> When
>
> > + you can enable the config. the DMA engine can only be used
>
> The
>
> > + with MediaTek SoCs.
> > +
>
above, i will modify.
> Also, use tabs to indent instead of spaces.
> The lines (tristate, depends, select, and help) should be indented with one tab.
> The help text lines should be indented with one tab + 2 spaces.
>
in my patch, i already do this. So don't need modify.
> > config MTK_HSDMA
> > tristate "MediaTek High-Speed DMA controller support"
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
>
> thanks,
next prev parent reply other threads:[~2019-01-10 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 2:12 [PATCH v9 0/2] add uart DMA function Long Cheng
2019-01-02 2:12 ` [PATCH v9 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support Long Cheng
2019-01-03 1:39 ` Nicolas Boichat
2019-01-03 2:03 ` Randy Dunlap
2019-01-10 8:50 ` Long Cheng [this message]
2019-01-10 8:24 ` Long Cheng
2019-01-04 17:19 ` Vinod Koul
2019-01-10 10:33 ` Long Cheng
2019-01-11 1:18 ` Long Cheng
2019-01-20 5:27 ` Vinod Koul
2019-01-21 8:12 ` Long Cheng
2019-01-02 2:12 ` [PATCH v9 2/2] arm: dts: mt2712: add uart APDMA to device tree Long Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547110225.3831.24.camel@mhfsdcap03 \
--to=long.cheng@mediatek.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=vkoul@kernel.org \
--cc=yingjoe.chen@mediatek.com \
--cc=yt.shen@mediatek.com \
--cc=zhenbao.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).