From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE503C43387 for ; Wed, 16 Jan 2019 09:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 952B22082F for ; Wed, 16 Jan 2019 09:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389218AbfAPJPe (ORCPT ); Wed, 16 Jan 2019 04:15:34 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:37765 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbfAPJPe (ORCPT ); Wed, 16 Jan 2019 04:15:34 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gjhIF-0005hu-2t; Wed, 16 Jan 2019 10:15:27 +0100 Message-ID: <1547630125.4339.20.camel@pengutronix.de> Subject: Re: [PATCH v2] dt-bindings: imx8mq: Number clocks consecutively From: Lucas Stach To: Guido =?ISO-8859-1?Q?G=FCnther?= , Shawn Guo , Rob Herring , Mark Rutland , Stephen Boyd , Abel Vesa , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 16 Jan 2019 10:15:25 +0100 In-Reply-To: <20190116084122.GA19712@bogon.m.sigxcpu.org> References: <20190116084122.GA19712@bogon.m.sigxcpu.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 16.01.2019, 09:41 +0100 schrieb Guido Günther: > This fixes a duplicate use of 232 and numbers the clocks without holes. > > Fixes: 1cf3817bf1f5 ("dt-bindings: Add binding for i.MX8MQ CCM") > > Signed-off-by: Guido Günther I agree that this should be applied as a fix for 5.0-rc. Reviewed-by: Lucas Stach > --- >  include/dt-bindings/clock/imx8mq-clock.h | 26 ++++++++++++------------ >  1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/include/dt-bindings/clock/imx8mq-clock.h b/include/dt-bindings/clock/imx8mq-clock.h > index b53be41929be..04f7ac345984 100644 > --- a/include/dt-bindings/clock/imx8mq-clock.h > +++ b/include/dt-bindings/clock/imx8mq-clock.h > @@ -350,7 +350,7 @@ > >  #define IMX8MQ_CLK_VPU_G2_ROOT 241 >   >  /* SCCG PLL GATE */ > > -#define IMX8MQ_SYS1_PLL_OUT 232 > > +#define IMX8MQ_SYS1_PLL_OUT 242 > >  #define IMX8MQ_SYS2_PLL_OUT 243 > >  #define IMX8MQ_SYS3_PLL_OUT 244 > >  #define IMX8MQ_DRAM_PLL_OUT 245 > @@ -372,24 +372,24 @@ >  /* txesc clock */ >  #define IMX8MQ_CLK_DSI_IPG_DIV                  256 >   > > -#define IMX8MQ_CLK_TMU_ROOT 265 > > +#define IMX8MQ_CLK_TMU_ROOT 257 >   >  /* Display root clocks */ > > -#define IMX8MQ_CLK_DISP_AXI_ROOT 266 > > -#define IMX8MQ_CLK_DISP_APB_ROOT 267 > > -#define IMX8MQ_CLK_DISP_RTRM_ROOT 268 > > +#define IMX8MQ_CLK_DISP_AXI_ROOT 258 > > +#define IMX8MQ_CLK_DISP_APB_ROOT 259 > > +#define IMX8MQ_CLK_DISP_RTRM_ROOT 260 >   > > -#define IMX8MQ_CLK_OCOTP_ROOT 269 > > +#define IMX8MQ_CLK_OCOTP_ROOT 261 >   > > -#define IMX8MQ_CLK_DRAM_ALT_ROOT 270 > > -#define IMX8MQ_CLK_DRAM_CORE 271 > > +#define IMX8MQ_CLK_DRAM_ALT_ROOT 262 > > +#define IMX8MQ_CLK_DRAM_CORE 263 >   > > -#define IMX8MQ_CLK_MU_ROOT 272 > > -#define IMX8MQ_VIDEO2_PLL_OUT 273 > > +#define IMX8MQ_CLK_MU_ROOT 264 > > +#define IMX8MQ_VIDEO2_PLL_OUT 265 >   > > -#define IMX8MQ_CLK_CLKO2 274 > > +#define IMX8MQ_CLK_CLKO2 266 >   > > -#define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 275 > > +#define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 267 >   > > -#define IMX8MQ_CLK_END 276 > > +#define IMX8MQ_CLK_END 268 >  #endif /* __DT_BINDINGS_CLOCK_IMX8MQ_H */