From: Robert Chiras <robert.chiras@nxp.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Philipp Zabel <p.zabel@pengutronix.de>,
Marek Vasut <marex@denx.de>
Cc: Robert Chiras <robert.chiras@nxp.com>,
Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
David Airlie <airlied@linux.ie>,
Anson Huang <anson.huang@nxp.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 05/11] drm/mxsfb: Fix the vblank events
Date: Wed, 16 Jan 2019 11:48:43 +0000 [thread overview]
Message-ID: <1547639306-19151-6-git-send-email-robert.chiras@nxp.com> (raw)
In-Reply-To: <1547639306-19151-1-git-send-email-robert.chiras@nxp.com>
Currently, the vblank support is not correctly implemented in MXSFB_DRM
driver. The call to drm_vblank_init is made with mode_config.num_crtc
which at that time is 0. Because of this, vblank is not activated, so
there won't be any vblank event submitted.
Signed-off-by: Robert Chiras <robert.chiras@nxp.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index bc1b750..d292192 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -43,6 +43,9 @@
#include "mxsfb_drv.h"
#include "mxsfb_regs.h"
+/* The eLCDIF max possible CRTCs */
+#define MAX_CRTCS 1
+
enum mxsfb_devtype {
MXSFB_V3,
MXSFB_V4,
@@ -138,6 +141,8 @@ static void mxsfb_pipe_enable(struct drm_simple_display_pipe *pipe,
mxsfb->connector = &mxsfb->panel_connector;
}
+ drm_crtc_vblank_on(&mxsfb->pipe.crtc);
+
pm_runtime_get_sync(drm->dev);
drm_panel_prepare(mxsfb->panel);
mxsfb_crtc_enable(mxsfb);
@@ -247,7 +252,7 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
pm_runtime_enable(drm->dev);
- ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
+ ret = drm_vblank_init(drm, MAX_CRTCS);
if (ret < 0) {
dev_err(drm->dev, "Failed to initialise vblank\n");
goto err_vblank;
@@ -270,6 +275,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
goto err_vblank;
}
+ drm_crtc_vblank_off(&mxsfb->pipe.crtc);
+
/*
* Attach panel only if there is one.
* If there is no panel attach, it must be a bridge. In this case, we
--
2.7.4
next prev parent reply other threads:[~2019-01-16 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 11:48 [PATCH 00/11] Add support for DRM bridge and additional pixel formats Robert Chiras
2019-01-16 11:48 ` [PATCH 01/11] drm/mxsfb: Update mxsfb to support a bridge Robert Chiras
2019-01-16 11:48 ` [PATCH 02/11] dt-bindings: display: Add max-res property for mxsfb Robert Chiras
2019-01-16 11:48 ` [PATCH 03/11] drm/mxsfb: Add max-res property for MXSFB Robert Chiras
2019-01-16 11:48 ` [PATCH 04/11] drm/mxsfb: Update mxsfb with additional pixel formats Robert Chiras
2019-01-16 11:48 ` Robert Chiras [this message]
2019-01-16 11:48 ` [PATCH 06/11] drm/mxsfb: Add support for new pixel formats in eLCDIF Robert Chiras
2019-01-16 11:48 ` [PATCH 07/11] drm/mxsfb: Signal mode changed when bpp changed Robert Chiras
2019-01-16 11:48 ` [PATCH 09/11] drm/mxsfb: Move pm_runtime_enable at the end of probe Robert Chiras
2019-01-16 11:48 ` [PATCH 08/11] drm/mxsfb: Update mxsfb to support LCD reset Robert Chiras
2019-01-16 11:48 ` [PATCH 10/11] drm/mxsfb: Improve the axi clock usage Robert Chiras
2019-01-16 11:48 ` [PATCH 11/11] drm/mxsfb: Clear OUTSTANDING_REQS bits Robert Chiras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547639306-19151-6-git-send-email-robert.chiras@nxp.com \
--to=robert.chiras@nxp.com \
--cc=airlied@linux.ie \
--cc=anson.huang@nxp.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).