From: "Martin J. Bligh" <mbligh@aracnet.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: Helge Hafting <helgehaf@aitel.hist.no>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.74-mm1 fails to boot due to APIC trouble, 2.5.73mm3 works.
Date: Fri, 04 Jul 2003 12:38:19 -0700 [thread overview]
Message-ID: <15480000.1057347497@[10.10.2.4]> (raw)
In-Reply-To: <20030704182617.GA955@holomorphy.com>
> On Fri, Jul 04, 2003 at 02:35:31AM -0700, William Lee Irwin III wrote:
>>>> Okay, now for the "final solution" wrt. sparse physical APIC ID's
>>>> in addition to what I hope is a fix for your bug. This uses a separate
>>>> bitmap type (of a NR_CPUS -independent width MAX_APICS) for physical
>>>> APIC ID bitmaps.
>>>> \begin{cross-fingers}
>
> On Fri, Jul 04, 2003 at 08:41:38AM -0700, Martin J. Bligh wrote:
>> Is it really necessary to turn half the apic code upside down in order
>> to fix this? What's the actual bugfix that's buried in this cleanup?
>> Despite the fact you seem to have gone out of your way to make this
>> hard to review, there are a few things I can see that strike me as odd.
>> Not necessarily wrong, but requiring more explanation.
>
> It's not a cleanup, and it doesn't touch trailing whitespace etc.
Maybe not, but it looks like one. Maybe if you actually explain
what you're trying to fix, and why?
I think this kind of change deserves a better explanation that
"I'm right" ... that's my main objection.
> On Fri, Jul 04, 2003 at 02:35:31AM -0700, William Lee Irwin III wrote:
>>> - if (i >= 0xf)
>>> + if (i >= APIC_BROADCAST_ID)
>
> On Fri, Jul 04, 2003 at 08:41:38AM -0700, Martin J. Bligh wrote:
>> Is that always correct? it's not equivalent.
>
> It is.
Explain. Not obvious to the casual observer.
> On Fri, Jul 04, 2003 at 02:35:31AM -0700, William Lee Irwin III wrote:
>>> diff -prauN mm1-2.5.74-1/include/asm-i386/mach-bigsmp/mach_apic.h physid-2.5.74-1/include/asm-i386/mach-bigsmp/mach_apic.h
>>> --- mm1-2.5.74-1/include/asm-i386/mach-bigsmp/mach_apic.h 2003-07-03 12:23:56.000000000 -0700
>>> +++ physid-2.5.74-1/include/asm-i386/mach-bigsmp/mach_apic.h 2003-07-04 02:47:45.000000000 -0700
>>> @@ -29,15 +29,15 @@ static inline cpumask_t target_cpus(void
>>> # define INT_DELIVERY_MODE dest_LowestPrio
>>> # define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */
>>> -#define APIC_BROADCAST_ID (0x0f)
>>> +#define APIC_BROADCAST_ID (0xff)
>
> On Fri, Jul 04, 2003 at 08:41:38AM -0700, Martin J. Bligh wrote:
>> So ... you've tested that change on a bigsmp machine, right?
>> At least, provide some reasoning here. Like this comment further down the
>> patch ...
>
> APIC_BROADCAST_ID is an upper bound on valid physical APIC ID's as it
> is used in the code. That actually was commented in the patch.
I find it odd that this worked before then. Also seems to be a separate
issue from the rest of the patch. Is quite probably correct, is just
non-obvious in the context of the rest of the patch.
> On Fri, Jul 04, 2003 at 02:35:31AM -0700, William Lee Irwin III wrote:
>>> +/*
>>> + * this isn't really broadcast, just a (potentially inaccurate) upper
>>> + * bound for valid physical APIC id's
>>> + */
>
> On Fri, Jul 04, 2003 at 08:41:38AM -0700, Martin J. Bligh wrote:
>> Which makes the change just look wrong to me. If you're thinking
>> "physical clustered mode" that terminology just utterly confusing crap,
>> and the change is wrong, as far as I can see.
>
> The change is correct, and I am not thinking of any such thing.
> APIC_BROADCAST_ID's sole usage is for terminating loops over physical
> APIC ID's while setting the physical APIC ID's of IO-APIC's.
Why is Summit 0xF, and bigsmp 0xFF then?
> On Fri, Jul 04, 2003 at 02:35:31AM -0700, William Lee Irwin III wrote:
>>> +++ physid-2.5.74-1/include/asm-i386/mach-numaq/mach_apic.h
>>> 2003-07-04 02:45:17.000000000 -0700
>>>
>>> -static inline cpumask_t apicid_to_cpu_present(int logical_apicid)
>>> +static inline physid_mask_t apicid_to_cpu_present(int logical_apicid)
>>> {
>>> int node = apicid_to_node(logical_apicid);
>>> int cpu = __ffs(logical_apicid & 0xf);
>>>
>>> - return cpumask_of_cpu(cpu + 4*node);
>>> + return physid_mask_of_physid(cpu + 4*node);
>>> }
>
> On Fri, Jul 04, 2003 at 08:41:38AM -0700, Martin J. Bligh wrote:
>> Hmmmm. What are you using physical apicids here for? They seem
>> irrelevant to this function.
>
> Look at where it's used.
I did. Still unclear why you think this is correct, or what physical
apicids have to do with a function that maps from apicids to the
phys_cpu_present_map, which is a compact mapping of logical apicids
for NUMA-Q.
Sorry, but this needs more explanation.
M.
next prev parent reply other threads:[~2003-07-04 19:24 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 9:37 2.5.74-mm1 Andrew Morton
2003-07-03 10:37 ` 2.5.74-mm1 Wiktor Wodecki
2003-07-03 11:06 ` 2.5.74-mm1 Russell King
2003-07-03 14:15 ` 2.5.74-mm1 Russell King
2003-07-03 16:05 ` 2.5.74-mm1 Patrick Mochel
2003-07-03 16:19 ` 2.5.74-mm1 Russell King
2003-07-03 16:24 ` 2.5.74-mm1 Patrick Mochel
2003-07-03 16:47 ` 2.5.74-mm1 Wiktor Wodecki
2003-07-03 18:43 ` 2.5.74-mm1 Serge Eric Thiam
2003-07-03 21:49 ` 2.5.74-mm1 Wiktor Wodecki
2003-07-03 21:53 ` 2.5.74-mm1 Russell King
2003-07-03 22:12 ` 2.5.74-mm1 Patrick Mochel
2003-07-03 22:14 ` 2.5.74-mm1 Russell King
2003-07-04 8:00 ` 2.5.74-mm1 Wiktor Wodecki
2003-07-03 11:27 ` pcmcia problem [was: Re: 2.5.74-mm1] Wiktor Wodecki
2003-07-03 10:45 ` 2.5.74-mm1 (p4-clockmod does not compile) Dumitru Ciobarcianu
2003-07-03 11:07 ` William Lee Irwin III
2003-07-03 11:17 ` Dumitru Ciobarcianu
2003-07-03 11:20 ` William Lee Irwin III
2003-07-03 11:32 ` 2.5.74-mm1 (p4-clockmod does not compile) PATCH Dumitru Ciobarcianu
2003-07-07 5:24 ` 2.5.74-mm1 (p4-clockmod does not compile) Zwane Mwaikambo
2003-07-07 5:47 ` William Lee Irwin III
2003-07-03 13:15 ` o1-interactivity.patch (was Re: 2.5.74-mm1) Sean Neakums
2003-07-03 13:30 ` Con Kolivas
2003-07-03 16:02 ` 2.5.74-mm1 Felipe Alfaro Solana
2003-07-03 18:11 ` 2.5.74-mm1 Pasi Savolainen
2003-07-03 20:25 ` 2.5.74-mm1 William Lee Irwin III
2003-07-03 20:48 ` 2.5.74-mm1 William Lee Irwin III
2003-07-04 8:55 ` 2.5.74-mm1 fails to boot due to APIC trouble, 2.5.73mm3 works Helge Hafting
2003-07-04 8:53 ` William Lee Irwin III
2003-07-04 9:35 ` William Lee Irwin III
2003-07-04 9:50 ` William Lee Irwin III
2003-07-04 10:02 ` William Lee Irwin III
2003-07-04 10:07 ` William Lee Irwin III
2003-07-04 11:12 ` Helge Hafting
2003-07-04 11:10 ` William Lee Irwin III
2003-07-04 12:50 ` Vincent Hanquez
2003-07-04 15:41 ` Martin J. Bligh
2003-07-04 15:47 ` Zwane Mwaikambo
2003-07-04 16:18 ` Martin J. Bligh
2003-07-04 16:16 ` Zwane Mwaikambo
2003-07-04 18:31 ` William Lee Irwin III
2003-07-04 19:20 ` Martin J. Bligh
2003-07-04 19:31 ` William Lee Irwin III
2003-07-04 19:53 ` Martin J. Bligh
2003-07-04 20:17 ` William Lee Irwin III
2003-07-04 18:32 ` William Lee Irwin III
2003-07-04 18:36 ` William Lee Irwin III
2003-07-04 18:29 ` William Lee Irwin III
2003-07-04 18:26 ` William Lee Irwin III
2003-07-04 19:38 ` Martin J. Bligh [this message]
2003-07-04 20:07 ` William Lee Irwin III
2003-07-04 20:37 ` Martin J. Bligh
2003-07-04 21:07 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 1:15 ` 2.5.74-mm1 Andrew Morton
2003-07-05 5:21 ` 2.5.74-mm1 Anton Blanchard
2003-07-05 11:18 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 11:46 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 10:44 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 18:43 ` 2.5.74-mm1 Andrew Morton
2003-07-05 21:17 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 21:27 ` 2.5.74-mm1 Andrew Morton
2003-07-05 22:03 ` 2.5.74-mm1 William Lee Irwin III
2003-07-05 0:16 ` 2.5.74-mm1 Daniel Phillips
2003-07-05 15:28 ` 2.5.74-mm1 Daniel Phillips
2003-07-05 16:01 ` 2.5.74-mm1 Con Kolivas
2003-07-05 17:47 ` 2.5.74-mm1 Daniel Phillips
2003-07-06 3:41 ` 2.5.74-mm1 Con Kolivas
2003-07-06 18:50 ` 2.5.74-mm1 Daniel Phillips
2003-07-05 19:14 ` 2.5.74-mm1 Andrew Morton
2003-07-05 21:09 ` 2.5.74-mm1 Daniel Phillips
2003-07-05 21:44 ` 2.5.74-mm1 Jamie Lokier
2003-07-05 22:10 ` 2.5.74-mm1 Daniel Phillips
2003-07-06 1:28 ` 2.5.74-mm1 Jamie Lokier
2003-07-06 2:14 ` 2.5.74-mm1 Daniel Phillips
2003-07-06 2:21 ` 2.5.74-mm1 Davide Libenzi
2003-07-06 13:54 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 10:00 ` 2.5.74-mm1 Mel Gorman
2003-07-07 12:24 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 13:09 ` 2.5.74-mm1 Alex Riesen
2003-07-07 14:33 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 14:34 ` 2.5.74-mm1 Alex Riesen
2003-07-07 13:16 ` 2.5.74-mm1 Mel Gorman
2003-07-07 14:47 ` 2.5.74-mm1 Davide Libenzi
2003-07-07 15:23 ` 2.5.74-mm1 Jamie Lokier
2003-07-07 17:25 ` 2.5.74-mm1 Davide Libenzi
2003-07-07 17:55 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 18:36 ` 2.5.74-mm1 Davide Libenzi
2003-07-07 19:07 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 22:03 ` 2.5.74-mm1 Davide Libenzi
2003-07-08 0:13 ` 2.5.74-mm1 Daniel Phillips
2003-07-08 0:29 ` 2.5.74-mm1 Davide Libenzi
2003-07-08 1:07 ` 2.5.74-mm1 Daniel Phillips
2003-07-08 7:48 ` 2.5.74-mm1 Davide Libenzi
2003-07-08 9:18 ` 2.5.74-mm1 Nick Piggin
2003-07-08 15:24 ` 2.5.74-mm1 Davide Libenzi
2003-07-09 0:36 ` 2.5.74-mm1 Nick Piggin
2003-07-08 11:09 ` 2.5.74-mm1 Daniel Phillips
2003-07-08 18:19 ` 2.5.74-mm1 Davide Libenzi
2003-07-08 19:12 ` 2.5.74-mm1 Davide Libenzi
2003-07-07 19:39 ` 2.5.74-mm1 Jamie Lokier
2003-07-07 19:36 ` 2.5.74-mm1 Jamie Lokier
2003-07-09 22:17 ` 2.5.74-mm1 Daniel Phillips
2003-07-09 22:24 ` 2.5.74-mm1 Jamie Lokier
2003-07-09 22:29 ` 2.5.74-mm1 Davide Libenzi
2003-07-09 23:15 ` 2.5.74-mm1 Daniel Phillips
2003-07-09 23:19 ` 2.5.74-mm1 Jamie Lokier
2003-07-09 22:59 ` 2.5.74-mm1 Daniel Phillips
2003-07-10 2:01 ` 2.5.74-mm1 Peter Chubb
2003-07-11 1:04 ` 2.5.74-mm1 Daniel Phillips
2003-07-11 1:08 ` 2.5.74-mm1 William Lee Irwin III
2003-07-11 5:44 ` 2.5.74-mm1 Davide Libenzi
2003-07-11 8:07 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 15:28 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 17:58 ` 2.5.74-mm1 Davide Libenzi
[not found] ` <Pine.LNX.4.55.0307070745250.4428@bigblue.dev.mcafeelabs.co m>
2003-07-07 17:15 ` 2.5.74-mm1 Mike Galbraith
2003-07-05 22:11 ` 2.5.74-mm1 Diego Calleja García
2003-07-05 23:31 ` 2.5.74-mm1 Daniel Phillips
2003-07-06 0:23 ` 2.5.74-mm1 Diego Calleja García
2003-07-06 22:59 ` 2.5.74-mm1 Jamie Lokier
2003-07-06 2:29 ` 2.5.74-mm1 Davide Libenzi
2003-07-06 0:10 ` 2.5.74-mm1 Daniel Phillips
2003-07-06 0:10 ` 2.5.74-mm1 Davide Libenzi
2003-07-05 19:40 ` 2.5.74-mm1 Diego Calleja García
2003-07-05 19:48 ` 2.5.74-mm1 Davide Libenzi
2003-07-05 21:22 ` 2.5.74-mm1 Daniel Phillips
2003-07-07 13:38 ` OOPS: 2.5.74-mm2 Maciej Soltysiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='15480000.1057347497@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@osdl.org \
--cc=helgehaf@aitel.hist.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).