From: qii wang <qii.wang@mediatek.com>
To: <wsa@the-dreams.de>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<qii.wang@mediatek.com>, <ryder.lee@mediatek.com>,
<xinping.qian@mediatek.com>, <liguo.zhang@mediatek.com>
Subject: [PATCH v3 2/6] i2c: mediatek: speeds is replaced by macros definitions
Date: Mon, 21 Jan 2019 15:59:30 +0800 [thread overview]
Message-ID: <1548057574-8061-3-git-send-email-qii.wang@mediatek.com> (raw)
In-Reply-To: <1548057574-8061-1-git-send-email-qii.wang@mediatek.com>
Different speeds have been defined by macros,
so we use macros definitions.
Signed-off-by: qii wang <qii.wang@mediatek.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
drivers/i2c/busses/i2c-mt65xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index a74ef76..7396449 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -456,7 +456,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
control_reg = readw(i2c->base + OFFSET_CONTROL) &
~(I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS);
- if ((i2c->speed_hz > 400000) || (left_num >= 1))
+ if ((i2c->speed_hz > MAX_FS_MODE_SPEED) || (left_num >= 1))
control_reg |= I2C_CONTROL_RS;
if (i2c->op == I2C_MASTER_WRRD)
@@ -465,7 +465,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
writew(control_reg, i2c->base + OFFSET_CONTROL);
/* set start condition */
- if (i2c->speed_hz <= 100000)
+ if (i2c->speed_hz <= I2C_DEFAULT_SPEED)
writew(I2C_ST_START_CON, i2c->base + OFFSET_EXT_CONF);
else
writew(I2C_FS_START_CON, i2c->base + OFFSET_EXT_CONF);
--
1.7.9.5
next prev parent reply other threads:[~2019-01-21 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 7:59 [PATCH v3 0/6] add i2c support for mt7629 and mt8183 qii wang
2019-01-21 7:59 ` [PATCH v3 1/6] dt-bindings: i2c: Add Mediatek MT7629 i2c binding qii wang
2019-02-05 13:10 ` Wolfram Sang
2019-01-21 7:59 ` qii wang [this message]
2019-02-05 13:11 ` [PATCH v3 2/6] i2c: mediatek: speeds is replaced by macros definitions Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 3/6] i2c: mediatek: remove completion_done() qii wang
2019-02-05 13:13 ` Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 4/6] i2c: mediatek: Add offsets array for new i2c registers qii wang
2019-01-21 7:59 ` [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding qii wang
2019-02-05 13:16 ` Wolfram Sang
2019-02-14 1:54 ` Qii Wang
2019-02-15 9:02 ` Wolfram Sang
2019-02-16 11:32 ` Qii Wang
2019-02-16 12:29 ` Wolfram Sang
2019-02-19 13:13 ` Qii Wang
2019-02-19 13:27 ` Wolfram Sang
2019-01-21 7:59 ` [PATCH v3 6/6] i2c: mediatek: Add i2c support for MediaTek MT8183 qii wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548057574-8061-3-git-send-email-qii.wang@mediatek.com \
--to=qii.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=ryder.lee@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=xinping.qian@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).