* [PATCH v2] usb: dwc3: exynos: Fix error handling of clk_prepare_enable
@ 2019-01-21 21:23 ` Alexey Khoroshilov
2019-01-22 8:20 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2019-01-21 21:23 UTC (permalink / raw)
To: Marek Szyprowski, Felipe Balbi
Cc: Alexey Khoroshilov, Kukjin Kim, Krzysztof Kozlowski, linux-usb,
linux-arm-kernel, linux-samsung-soc, linux-kernel, ldv-project
If clk_prepare_enable() fails in dwc3_exynos_probe() or in
dwc3_exynos_resume(), exynos->clks[0] is left undisabled
because of usage preincrement in while condition.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants")
---
v2: Add fix for the second instance in dwc3_exynos_resume() per Marek Szyprowski note.
drivers/usb/dwc3/dwc3-exynos.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index cb7fcd7c0ad8..c1e9ea621f41 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
for (i = 0; i < exynos->num_clks; i++) {
ret = clk_prepare_enable(exynos->clks[i]);
if (ret) {
- while (--i > 0)
+ while (i-- > 0)
clk_disable_unprepare(exynos->clks[i]);
return ret;
}
@@ -223,7 +223,7 @@ static int dwc3_exynos_resume(struct device *dev)
for (i = 0; i < exynos->num_clks; i++) {
ret = clk_prepare_enable(exynos->clks[i]);
if (ret) {
- while (--i > 0)
+ while (i-- > 0)
clk_disable_unprepare(exynos->clks[i]);
return ret;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: dwc3: exynos: Fix error handling of clk_prepare_enable
2019-01-21 21:23 ` [PATCH v2] usb: dwc3: exynos: Fix error handling of clk_prepare_enable Alexey Khoroshilov
@ 2019-01-22 8:20 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2019-01-22 8:20 UTC (permalink / raw)
To: Alexey Khoroshilov, Felipe Balbi
Cc: Kukjin Kim, Krzysztof Kozlowski, linux-usb, linux-arm-kernel,
linux-samsung-soc, linux-kernel, ldv-project
Hi Alexey,
On 2019-01-21 22:23, Alexey Khoroshilov wrote:
> If clk_prepare_enable() fails in dwc3_exynos_probe() or in
> dwc3_exynos_resume(), exynos->clks[0] is left undisabled
> because of usage preincrement in while condition.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Fixes: 9f2168367a0a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants")
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> v2: Add fix for the second instance in dwc3_exynos_resume() per Marek Szyprowski note.
>
> drivers/usb/dwc3/dwc3-exynos.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index cb7fcd7c0ad8..c1e9ea621f41 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
> for (i = 0; i < exynos->num_clks; i++) {
> ret = clk_prepare_enable(exynos->clks[i]);
> if (ret) {
> - while (--i > 0)
> + while (i-- > 0)
> clk_disable_unprepare(exynos->clks[i]);
> return ret;
> }
> @@ -223,7 +223,7 @@ static int dwc3_exynos_resume(struct device *dev)
> for (i = 0; i < exynos->num_clks; i++) {
> ret = clk_prepare_enable(exynos->clks[i]);
> if (ret) {
> - while (--i > 0)
> + while (i-- > 0)
> clk_disable_unprepare(exynos->clks[i]);
> return ret;
> }
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-22 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190121212507epcas1p1f2b689e91046a2736ed26a84367c210a@epcas1p1.samsung.com>
2019-01-21 21:23 ` [PATCH v2] usb: dwc3: exynos: Fix error handling of clk_prepare_enable Alexey Khoroshilov
2019-01-22 8:20 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).