From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Thierry Reding <thierry.reding@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-tegra@vger.kernel.org,
Boris Brezillon <bbrezillon@kernel.org>,
Lucas Stach <dev@lynxeye.de>
Subject: [PATCH 0/2] mtd: nand: use unnamed union field
Date: Tue, 22 Jan 2019 16:42:53 +0900 [thread overview]
Message-ID: <1548142975-14219-1-git-send-email-yamada.masahiro@socionext.com> (raw)
The new exec_op() scheme takes advantage of union
in order to store instruction private data, which is mutually
exclusive.
I felt a bit annoyed with the long accessors.
At least, we can omit "ctx." by making the union anonymous.
I converted nand_op_instr and nand_op_parser_pattern_elem.
I still see more instances, e.g.
struct nand_op_data_instr {
unsigned int len;
union {
void *in;
const void *out;
} buf;
bool force_8bit;
};
We could convert this into:
struct nand_op_data_instr {
unsigned int len;
union {
void *ibuf;
const void *obuf;
};
bool force_8bit;
};
Or, if we want to match the struct to NAND_OP_*_INSTR,
we can split it into two structures.
struct nand_op_data_in_instr {
unsigned int len;
void *buf;
bool force_8bit;
};
struct nand_op_data_out_instr {
unsigned int len;
const void *buf;
bool force_8bit;
};
Anyway, let's see if people are positive about
this shortning.
Masahiro Yamada (2):
mtd: rawnand: use unnamed union in struct nand_op_instr
mtd: rawnand: use unnamed union in struct nand_op_parser_pattern_elem
drivers/mtd/nand/raw/ams-delta.c | 18 +++++------
drivers/mtd/nand/raw/fsmc_nand.c | 41 +++++++++++-------------
drivers/mtd/nand/raw/marvell_nand.c | 16 +++++-----
drivers/mtd/nand/raw/nand_base.c | 64 ++++++++++++++++++-------------------
drivers/mtd/nand/raw/tegra_nand.c | 10 +++---
drivers/mtd/nand/raw/vf610_nfc.c | 14 ++++----
include/linux/mtd/rawnand.h | 36 ++++++++++-----------
7 files changed, 97 insertions(+), 102 deletions(-)
--
2.7.4
next reply other threads:[~2019-01-22 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 7:42 Masahiro Yamada [this message]
2019-01-22 7:42 ` [PATCH 1/2] mtd: rawnand: use unnamed union in struct nand_op_instr Masahiro Yamada
2019-01-22 7:42 ` [PATCH 2/2] mtd: rawnand: use unnamed union in struct nand_op_parser_pattern_elem Masahiro Yamada
2019-01-22 7:49 ` Miquel Raynal
2019-01-22 8:00 ` Masahiro Yamada
2019-01-22 8:08 ` Miquel Raynal
2019-01-22 8:33 ` Boris Brezillon
2019-01-22 8:55 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548142975-14219-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dev@lynxeye.de \
--cc=dwmw2@infradead.org \
--cc=jmkrzyszt@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).