From: Nicholas Mc Guire <hofrat@osadl.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH] livepatch: fix size mismatch
Date: Wed, 23 Jan 2019 11:31:16 +0100 [thread overview]
Message-ID: <1548239476-21110-1-git-send-email-hofrat@osadl.org> (raw)
kzalloc(sizeof(int)) is called for an int object but then
passed into klp_shadow_alloc() using the size of the pointer.
This probably is not a problem as it will fit - but it should
be cleaned (after all this is reference code).
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Reported by coccicheck
samples/livepatch//livepatch-shadow-fix1.c:97:30-36: ERROR: application of sizeof to pointer
Patch was compile tested with: x86_64_defconfig + FTRACE=y,
FUNCTION_TRACER=y, SAMPLES=y, LIVEPATCH=y SAMPLE_LIVEPATCH=m
Patch is against 5.0-rc3 (localversion-next is next-20190123)
samples/livepatch/livepatch-shadow-fix1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/livepatch/livepatch-shadow-fix1.c b/samples/livepatch/livepatch-shadow-fix1.c
index a5a5cac..643ffd5 100644
--- a/samples/livepatch/livepatch-shadow-fix1.c
+++ b/samples/livepatch/livepatch-shadow-fix1.c
@@ -94,7 +94,7 @@ struct dummy *livepatch_fix1_dummy_alloc(void)
return NULL;
}
- klp_shadow_alloc(d, SV_LEAK, sizeof(leak), GFP_KERNEL,
+ klp_shadow_alloc(d, SV_LEAK, sizeof(*leak), GFP_KERNEL,
shadow_leak_ctor, leak);
pr_info("%s: dummy @ %p, expires @ %lx\n",
--
2.1.4
next reply other threads:[~2019-01-23 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 10:31 Nicholas Mc Guire [this message]
2019-01-23 14:58 ` [PATCH] livepatch: fix size mismatch Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548239476-21110-1-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).