From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1652DC282C3 for ; Fri, 25 Jan 2019 02:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA7A5218CD for ; Fri, 25 Jan 2019 02:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbfAYC2o (ORCPT ); Thu, 24 Jan 2019 21:28:44 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:15543 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728372AbfAYC2m (ORCPT ); Thu, 24 Jan 2019 21:28:42 -0500 X-UUID: 7d55a966bba44f91bc7928b74472a746-20190125 X-UUID: 7d55a966bba44f91bc7928b74472a746-20190125 Received: from mtkcas32.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2046741440; Fri, 25 Jan 2019 10:28:37 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS33DR.mediatek.inc (172.27.6.106) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 25 Jan 2019 10:28:36 +0800 Received: from [10.16.6.141] (10.16.6.141) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 25 Jan 2019 10:28:35 +0800 Message-ID: <1548383315.19561.4.camel@mszsdaap41> Subject: Re: [PATCH V2,4/8] drm/mediatek: fix the rate and divder of hdmi phy for MT2701 From: mtk14994 To: CK Hu CC: Michael Turquette , Matthias Brugger , Stephen Boyd , Philipp Zabel , David Airlie , chunhui dai , Sean Wang , Ryder Lee , Colin Ian King , , , , , , , , Date: Fri, 25 Jan 2019 10:28:35 +0800 In-Reply-To: <1548310639.4220.3.camel@mtksdaap41> References: <20190118125928.3279-1-wangyan.wang@mediatek.com> <20190118125928.3279-5-wangyan.wang@mediatek.com> <1548310639.4220.3.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear CK, OK,I will modify according your comments in V3. Best Regards Wangyan Wang On Thu, 2019-01-24 at 14:17 +0800, CK Hu wrote: > On Fri, 2019-01-18 at 20:59 +0800, Wangyan Wang wrote: > > From: chunhui dai > > Describe something here. > > > > > Fixes: 0fc721b2968e ("drm/mediatek: add hdmi driver for MT2701 and MT7623") > > Signed-off-by: chunhui dai > > Any one who pass a patch should sign off it. > > Regards, > CK > > > --- > > drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > > index 43bc058d5528..88dd9e812ca0 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > > +++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > > @@ -114,8 +114,8 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, > > > > if (rate <= 64000000) > > pos_div = 3; > > - else if (rate <= 12800000) > > - pos_div = 1; > > + else if (rate <= 128000000) > > + pos_div = 2; > > else > > pos_div = 1; > > > >