From: Lucas Stach <l.stach@pengutronix.de>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: angus.ainslie@puri.sm, Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Daniel Baluta <daniel.baluta@gmail.com>
Subject: Re: [PATCH v4 5/5] imx8mq.dtsi: add the sdma nodes
Date: Fri, 25 Jan 2019 10:38:27 +0100 [thread overview]
Message-ID: <1548409107.28802.36.camel@pengutronix.de> (raw)
In-Reply-To: <20190125025528.15645-6-angus@akkea.ca>
Am Donnerstag, den 24.01.2019, 19:55 -0700 schrieb Angus Ainslie (Purism):
> Add the sdma nodes to the base devicetree for the imx8mq
>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
One nit below, with that fixed:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
You might need to split this patch out from the series and send it to
Shawn separately after the dmaengine changes have been accepted.
regards,
Lucas
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 28 +++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index c0402375e7c1..f0cd3675ead0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -336,6 +336,17 @@
> > clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>;
> > status = "disabled";
> > };
> +
> > > + sdma2: sdma@302c0000 {
> > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma";
> > + reg = <0x302c0000 0x10000>;
> > + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>,
> + <&clk IMX8MQ_CLK_SDMA2_ROOT>;
Some spaces to align the second clock reference as in the rest of this
file, please.
> + clock-names = "ipg", "ahb";
> > + #dma-cells = <3>;
> > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
> > + };
> > };
>
> > bus@30400000 { /* AIPS2 */
> @@ -370,6 +381,8 @@
> > clocks = <&clk IMX8MQ_CLK_UART3_ROOT>,
> > <&clk IMX8MQ_CLK_UART3_ROOT>;
> > clock-names = "ipg", "per";
> > + dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
> > + dma-names = "rx", "tx";
> > status = "disabled";
> > };
>
> @@ -381,6 +394,8 @@
> > clocks = <&clk IMX8MQ_CLK_UART2_ROOT>,
> > <&clk IMX8MQ_CLK_UART2_ROOT>;
> > clock-names = "ipg", "per";
> > + dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> > + dma-names = "rx", "tx";
> > status = "disabled";
> > };
>
> @@ -432,6 +447,8 @@
> > clocks = <&clk IMX8MQ_CLK_UART4_ROOT>,
> > <&clk IMX8MQ_CLK_UART4_ROOT>;
> > clock-names = "ipg", "per";
> > + dmas = <&sdma1 28 4 0>, <&sdma1 29 4 0>;
> > + dma-names = "rx", "tx";
> > status = "disabled";
> > };
>
> @@ -465,6 +482,17 @@
> > status = "disabled";
> > };
>
> > > + sdma1: sdma@30bd0000 {
> > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma";
> > + reg = <0x30bd0000 0x10000>;
> > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>,
> > + <&clk IMX8MQ_CLK_AHB>;
> > + clock-names = "ipg", "ahb";
> > + #dma-cells = <3>;
> > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
> > + };
> +
> > > fec1: ethernet@30be0000 {
> > compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec";
> > reg = <0x30be0000 0x10000>;
next prev parent reply other threads:[~2019-01-25 9:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 2:31 [PATCH v2 0/3] dma: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-20 2:31 ` [PATCH v2 1/3] dma: imx-sdma: fix NULL pointer de-reference Angus Ainslie (Purism)
2019-01-20 9:54 ` Daniel Baluta
2019-01-20 15:04 ` Angus Ainslie
2019-01-20 2:31 ` [PATCH v2 2/3] dma: imx-sdma: add clock ratio 1:1 check Angus Ainslie (Purism)
2019-01-20 9:58 ` Daniel Baluta
2019-01-20 14:38 ` Angus Ainslie
2019-01-20 18:00 ` Daniel Baluta
2019-01-21 9:17 ` Lucas Stach
2019-01-21 14:43 ` Angus Ainslie
2019-01-20 2:31 ` [PATCH v2 3/3] imx8mq.dtsi: add the sdma nodes Angus Ainslie (Purism)
2019-01-23 15:23 ` [PATCH v3 0/5] dma: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-23 15:23 ` [PATCH v3 1/5] dma: imx-sdma: add clock ratio 1:1 check Angus Ainslie (Purism)
2019-01-23 15:43 ` Lucas Stach
2019-01-23 15:23 ` [PATCH v3 2/5] dma: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie (Purism)
2019-01-23 15:23 ` [PATCH v3 3/5] dt-bindings: dma: fsl-imx-sdma: add imx8mq compatible string Angus Ainslie (Purism)
2019-01-23 15:23 ` [PATCH v3 4/5] dma: imx-sdma: add an index for imx8mq multi sdma devices Angus Ainslie (Purism)
2019-01-23 15:31 ` Lucas Stach
2019-01-23 15:42 ` Angus Ainslie
2019-01-23 15:55 ` Vinod Koul
2019-01-23 15:23 ` [PATCH v3 5/5] imx8mq.dtsi: add the sdma nodes Angus Ainslie (Purism)
2019-01-23 16:50 ` Lucas Stach
2019-01-25 2:55 ` [PATCH v4 0/5] dmaengine: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-25 2:55 ` [PATCH v4 1/5] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie (Purism)
2019-01-25 9:42 ` Lucas Stach
2019-01-25 2:55 ` [PATCH v4 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie (Purism)
2019-01-25 9:35 ` Lucas Stach
2019-01-25 2:55 ` [PATCH v4 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq to the accepted compatible node Angus Ainslie (Purism)
2019-01-25 9:39 ` Lucas Stach
2019-01-25 2:55 ` [PATCH v4 4/5] dma: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie (Purism)
2019-01-25 9:34 ` Lucas Stach
2019-01-25 2:55 ` [PATCH v4 5/5] imx8mq.dtsi: add the sdma nodes Angus Ainslie (Purism)
2019-01-25 9:38 ` Lucas Stach [this message]
2019-01-28 6:08 ` [PATCH v5 0/5] dmaengine: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-28 6:08 ` [PATCH v5 1/5] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie (Purism)
2019-01-28 9:29 ` Lucas Stach
2019-01-28 6:08 ` [PATCH v5 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts Angus Ainslie (Purism)
2019-01-28 9:32 ` Lucas Stach
2019-01-28 6:08 ` [PATCH v5 3/5] dt-bindings: dma: fsl-imx-sdma: add fsl,imx8mq to the accepted compatible node Angus Ainslie (Purism)
2019-01-28 6:08 ` [PATCH v5 4/5] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie (Purism)
2019-01-28 9:33 ` Lucas Stach
2019-01-28 6:08 ` [PATCH v5 5/5] dmaengine: imx-sdma: fix consistent dma test failures Angus Ainslie (Purism)
2019-01-28 16:03 ` [PATCH v6 0/3] dmaengine: imx-sdma: add the sdma engine to the imx8mq Angus Ainslie (Purism)
2019-01-28 16:03 ` [PATCH v6 1/3] dmaengine: imx-sdma: add clock ratio 1:1 check Angus Ainslie (Purism)
2019-01-28 16:03 ` [PATCH v6 2/3] dmaengine: imx-sdma: add a test for imx8mq multi sdma devices Angus Ainslie (Purism)
2019-02-25 13:31 ` Daniel Baluta
2019-01-28 16:03 ` [PATCH v6 3/3] dmaengine: imx-sdma: fix consistent dma test failures Angus Ainslie (Purism)
2019-02-25 17:56 ` [PATCH v6 0/3] dmaengine: imx-sdma: add the sdma engine to the imx8mq Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548409107.28802.36.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=daniel.baluta@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).