From: Lucas Stach <l.stach@pengutronix.de>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support
Date: Fri, 25 Jan 2019 11:46:09 +0100 [thread overview]
Message-ID: <1548413169.28802.43.camel@pengutronix.de> (raw)
In-Reply-To: <1547797668-30342-3-git-send-email-aisheng.dong@nxp.com>
Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong:
> One irqsteer channel can support up to 8 output interrupts.
>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> index eaabcda..beeed4a 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> @@ -6,8 +6,9 @@ Required properties:
> > - "fsl,imx8m-irqsteer"
> > - "fsl,imx-irqsteer"
> - reg: Physical base address and size of registers.
> -- interrupts: Should contain the parent interrupt line used to multiplex the
> - input interrupts.
> +- interrupts: Should contain the up to 8 parent interrupt lines used to
> + multiplex the input interrupts. They should be sepcified seqencially
> + from output 0 to 7. NOTE at least one output interrupt has to be specified.
I don't think the note clarifies anything. Given that the thing is a
irq multiplexer I don't think anyone expects that you could get away
with no output irq.
If anything this should specify that it's always groups of (up to) 64
input irqs being muxed onto a single output irq.
Regards,
Lucas
next prev parent reply other threads:[~2019-01-25 10:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 7:53 [PATCH 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong
2019-01-18 7:53 ` [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Aisheng Dong
2019-01-18 8:48 ` Lucas Stach
2019-01-18 9:39 ` Marc Zyngier
2019-01-18 9:46 ` Aisheng Dong
2019-01-18 10:12 ` Marc Zyngier
2019-01-22 10:56 ` Aisheng Dong
2019-01-22 11:05 ` Lucas Stach
2019-01-22 11:48 ` Marc Zyngier
2019-01-18 9:45 ` Aisheng Dong
2019-01-18 7:53 ` [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong
2019-01-25 10:46 ` Lucas Stach [this message]
2019-01-27 14:05 ` Dong Aisheng
2019-01-18 7:53 ` [PATCH 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong
2019-01-18 7:53 ` [PATCH 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong
2019-01-18 8:53 ` Lucas Stach
2019-01-18 9:54 ` Aisheng Dong
2019-01-18 10:22 ` Lucas Stach
2019-01-22 10:39 ` Aisheng Dong
2019-01-22 10:59 ` Lucas Stach
2019-01-22 12:03 ` Aisheng Dong
2019-01-22 12:52 ` Lucas Stach
2019-01-22 13:17 ` Aisheng Dong
2019-01-25 10:42 ` Lucas Stach
2019-01-27 10:38 ` Dong Aisheng
2019-01-22 12:50 ` Aisheng Dong
2019-01-25 10:54 ` Lucas Stach
2019-01-27 14:02 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548413169.28802.43.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).