From: Philipp Zabel <p.zabel@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: Don't WARN if trying to get a used reset control
Date: Mon, 28 Jan 2019 12:26:48 +0100 [thread overview]
Message-ID: <1548674808.6421.3.camel@pengutronix.de> (raw)
In-Reply-To: <20190125101554.5947-1-thierry.reding@gmail.com>
Hi Thierry,
On Fri, 2019-01-25 at 11:15 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> When requesting a reset control for exclusive use that's already in use,
> an -EBUSY error code is returned. Users can react accordingly when they
> receive that error code, so there is no need to loudly complain.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/reset/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index 9582efb70025..6b452f010b66 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -416,7 +416,7 @@ static struct reset_control *__reset_control_get_internal(
>
> list_for_each_entry(rstc, &rcdev->reset_control_head, list) {
> if (rstc->id == index) {
> - if (WARN_ON(!rstc->shared || !shared))
> + if (!rstc->shared || !shared)
> return ERR_PTR(-EBUSY);
>
> kref_get(&rstc->refcnt);
Are you actually running into this somewhere?
My reason for adding these warnings was that these point to either a DT
misconfiguration or a driver bug, and the verbose warning helps to
quickly identify the actual issue. This is not an error condition that
I would expect on a correctly configured system.
I don't expect most drivers give a proper error message that contains
the -EBUSY return value. Usually it's just along the lines of "failed to
get reset control" without any further indication.
regards
Philipp
next prev parent reply other threads:[~2019-01-28 11:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 10:15 [PATCH] reset: Don't WARN if trying to get a used reset control Thierry Reding
2019-01-28 11:26 ` Philipp Zabel [this message]
2019-01-28 14:58 ` Thierry Reding
2019-01-30 12:03 ` Philipp Zabel
2019-02-01 14:00 ` Thierry Reding
2019-02-05 18:05 ` Philipp Zabel
2019-02-05 22:13 ` Thierry Reding
2019-02-06 10:28 ` Philipp Zabel
2019-02-06 11:38 ` Thierry Reding
2019-02-06 14:46 ` Philipp Zabel
2019-02-06 16:00 ` Thierry Reding
2019-02-06 18:12 ` Philipp Zabel
2019-02-07 8:27 ` Thierry Reding
2019-02-20 8:49 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548674808.6421.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).