archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <>
To: Alexandre Belloni <>
Cc: Zhou Yanjie <>,
	Lars-Peter Clausen <>,,,,,,,,,,,
Subject: Re: Add Ingenic X1000 RTC support.
Date: Mon, 28 Jan 2019 17:48:04 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


> Hello,
> This seems like a useless renaming to me, can you elaborate a bit 
> more?
> I'd also like to have Paul and Lars-Peter comment.

According to the patchset, the RTC in the X1000 does not behave any 
than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped.
In your devicetree bindings, just use the "ingenic,jz4780-rtc" 
string instead. The same goes for all the drivers (e.g. the uart one).

I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" 
just "Ingenic SoCs" since XBurst is just the name of the CPU inside 


  reply	other threads:[~2019-01-28 20:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 17:29 Zhou Yanjie
2019-01-28 17:29 ` [PATCH 1/3] RTC: Ingenic: Add support for the X1000 Zhou Yanjie
2019-01-28 17:29 ` [PATCH 2/3] Dt-bindings: RTC: Add X1000 RTC bindings Zhou Yanjie
2019-01-28 20:11   ` Alexandre Belloni
2019-01-28 17:29 ` [PATCH 3/3] RTC: Ingenic: Replace jz47xx with XBurst Zhou Yanjie
2019-01-28 20:13   ` Alexandre Belloni
2019-01-28 20:10 ` Add Ingenic X1000 RTC support Alexandre Belloni
2019-01-28 20:48   ` Paul Cercueil [this message]
2019-01-29  3:53     ` Zhou Yanjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: Add Ingenic X1000 RTC support.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).