From: Stefan Wahren <stefan.wahren@i2se.com>
To: Kamil Debski <kamil@wypas.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH 2/2] hwmon: pwm-fan: Add optional regulator support
Date: Tue, 29 Jan 2019 18:07:11 +0100 [thread overview]
Message-ID: <1548781631-5736-2-git-send-email-stefan.wahren@i2se.com> (raw)
In-Reply-To: <1548781631-5736-1-git-send-email-stefan.wahren@i2se.com>
This adds optional regulator support to the pwm-fan driver. This is
necessary for pwm fans which are powered by a switchable supply.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/hwmon/pwm-fan.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 2c94482..9e0591e 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -23,6 +23,7 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pwm.h>
+#include <linux/regulator/consumer.h>
#include <linux/sysfs.h>
#include <linux/thermal.h>
@@ -31,6 +32,7 @@
struct pwm_fan_ctx {
struct mutex lock;
struct pwm_device *pwm;
+ struct regulator *reg_en;
unsigned int pwm_value;
unsigned int pwm_fan_state;
unsigned int pwm_fan_max_state;
@@ -244,6 +246,23 @@ static int pwm_fan_probe(struct platform_device *pdev)
return ret;
}
+ ctx->reg_en = devm_regulator_get_optional(&pdev->dev, "fan");
+ if (!IS_ERR(ctx->reg_en)) {
+ ret = regulator_enable(ctx->reg_en);
+ if (ret)
+ dev_err(&pdev->dev,
+ "Failed to enable fan supply: %d\n", ret);
+ } else {
+ switch (PTR_ERR(ctx->reg_en)) {
+ case -ENODEV:
+ case -ENOSYS:
+ ctx->reg_en = NULL;
+ break;
+ default:
+ return PTR_ERR(ctx->reg_en);
+ }
+ }
+
hwmon = devm_hwmon_device_register_with_groups(&pdev->dev, "pwmfan",
ctx, pwm_fan_groups);
if (IS_ERR(hwmon)) {
@@ -287,6 +306,10 @@ static int pwm_fan_remove(struct platform_device *pdev)
thermal_cooling_device_unregister(ctx->cdev);
if (ctx->pwm_value)
pwm_disable(ctx->pwm);
+
+ if (ctx->reg_en)
+ regulator_disable(ctx->reg_en);
+
return 0;
}
@@ -299,6 +322,12 @@ static int pwm_fan_suspend(struct device *dev)
pwm_get_args(ctx->pwm, &args);
+ if (ctx->reg_en) {
+ ret = regulator_disable(ctx->reg_en);
+ if (ret)
+ dev_err(dev, "Failed to disable fan supply: %d\n", ret);
+ }
+
if (ctx->pwm_value) {
ret = pwm_config(ctx->pwm, 0, args.period);
if (ret < 0)
@@ -317,6 +346,12 @@ static int pwm_fan_resume(struct device *dev)
unsigned long duty;
int ret;
+ if (ctx->reg_en) {
+ ret = regulator_enable(ctx->reg_en);
+ if (ret)
+ dev_err(dev, "Failed to enable fan supply: %d\n", ret);
+ }
+
if (ctx->pwm_value == 0)
return 0;
--
2.7.4
next prev parent reply other threads:[~2019-01-29 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 17:07 [PATCH 1/2] dt-bindings: hwmon: Add optional regulator support to pwm-fan Stefan Wahren
2019-01-29 17:07 ` Stefan Wahren [this message]
2019-01-31 17:56 ` [PATCH 2/2] hwmon: pwm-fan: Add optional regulator support Guenter Roeck
2019-02-01 10:38 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548781631-5736-2-git-send-email-stefan.wahren@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).