From: Lucas Stach <l.stach@pengutronix.de>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH V2 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number
Date: Wed, 30 Jan 2019 14:17:47 +0100 [thread overview]
Message-ID: <1548854267.6869.21.camel@pengutronix.de> (raw)
In-Reply-To: <1548853196-11447-2-git-send-email-aisheng.dong@nxp.com>
Am Mittwoch, den 30.01.2019, 13:05 +0000 schrieb Aisheng Dong:
> Not all 64 interrupts may be used in one group. e.g. most irqsteer in
> imx8qxp and imx8qm subsystems supports only 32 interrupts.
>
> As the IP integration parameters are Channel number and interrupts number,
> let's use fsl,num-irqs to represents how many interrupts supported
> by this irqsteer channel.
>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
As the original fsl,irq-groups was born out of a misunderstanding of
the HW config options and I'm not aware of any users of the current
binding, I'm fine with merging this. I do think this warrants a
backport to stable though, so we don't end up with different bindings
in stable and current kernels.
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> ChangeLog:
> v1->v2:
> * change property name fsl,irqs-per-chan to fsl,num-irqs.
> ---
> .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> index 45790ce..6d0a41b 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> @@ -16,8 +16,8 @@ Required properties:
> - #interrupt-cells: Specifies the number of cells needed to encode an
> interrupt source. The value must be 1.
> - fsl,channel: The output channel that all input IRQs should be steered into.
> -- fsl,irq-groups: Number of IRQ groups managed by this controller instance.
> - Each group manages 64 input interrupts.
> +- fsl,num-irqs: Number of input interrupts of this channel.
> + Should be multiple of 32 input interrupts and up to 512 interrupts.
>
> Example:
>
> @@ -28,7 +28,7 @@ Example:
> > clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > clock-names = "ipg";
> > fsl,channel = <0>;
> > - fsl,irq-groups = <1>;
> > + fsl,num-irqs = <64>;
> > interrupt-controller;
> > #interrupt-cells = <1>;
> > };
next prev parent reply other threads:[~2019-01-30 13:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 13:05 [PATCH V2 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong
2019-01-30 13:05 ` [PATCH V2 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number Aisheng Dong
2019-01-30 13:17 ` Lucas Stach [this message]
2019-01-30 13:05 ` [PATCH V2 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong
2019-01-30 13:18 ` Lucas Stach
2019-01-30 13:33 ` Dong Aisheng
2019-01-30 13:06 ` [PATCH V2 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong
2019-01-30 13:22 ` Lucas Stach
2019-01-31 7:27 ` Dong Aisheng
2019-01-30 13:06 ` [PATCH V2 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong
2019-01-30 13:32 ` Lucas Stach
2019-01-30 14:03 ` Dong Aisheng
2019-01-30 14:11 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548854267.6869.21.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).