From: Stephen Boyd <sboyd@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, Joel Stanley <joel@jms.id.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] clk: aspeed: Setup video engine clocking
Date: Wed, 30 Jan 2019 11:28:19 -0800 [thread overview]
Message-ID: <154887649939.169292.7755423118611897741@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <81b100b7-252e-3145-fb34-17a9c0cdd91e@linux.ibm.com>
Quoting Eddie James (2018-12-14 07:47:53)
>
>
> On 12/13/2018 07:02 PM, Joel Stanley wrote:
>
> >
> >> + { 0x0, 2 },
> >> + { 0x1, 2 },
> >> + { 0x2, 3 },
> >> + { 0x3, 4 },
> >> + { 0x4, 5 },
> >> + { 0x5, 6 },
> >> + { 0x6, 7 },
> >> + { 0x7, 8 },
> >> + { 0 }
> >> +};
> >> @@ -317,6 +338,7 @@ struct aspeed_reset {
> >> [ASPEED_RESET_PECI] = 10,
> >> [ASPEED_RESET_I2C] = 2,
> >> [ASPEED_RESET_AHB] = 1,
> >> + [ASPEED_RESET_VIDEO] = 6,
> > You've added the reset line to the ASPEED_CLK_GATE_ECLK clock so you
> > do not need to separately expose the reset controller. Instead
> > enabling the clock will deassert the rest line for you.
> >
> > This means you should drop the change from the header too, and it
> > affects the bindings document for the video engine.
>
> I want that reset available separately for use in the video engine
> actually. I could do without it, but it's somewhat useful.
>
Joel, are you happy with these patches? I'm tempted to drop these
changes from my queue because there hasn't been any news in over a
month.
prev parent reply other threads:[~2019-01-30 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 20:12 [PATCH 0/2] clk: aspeed: Setup video engine clocking Eddie James
2018-12-11 20:12 ` [PATCH 1/2] clk: aspeed: Add video engine reset index definition Eddie James
2018-12-11 20:12 ` [PATCH 2/2] clk: aspeed: Setup video engine clocking Eddie James
2018-12-14 1:02 ` Joel Stanley
2018-12-14 15:47 ` Eddie James
2019-01-30 19:28 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154887649939.169292.7755423118611897741@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).